Bug 1307009 - Restrict the CSS properties db test to only nightly; r?tromey draft
authorGreg Tatum <tatum.creative@gmail.com>
Tue, 04 Oct 2016 14:58:28 -0500
changeset 420822 5a25239533a110fe2a0adcd3d177d6b420405852
parent 420680 42c95d88aaaa7c2eca1d278399421d437441ac4d
child 420823 544e67e963c9f7234d6adc4445c6af20e14baa19
child 420826 44f9087321f1b4828a511a09d2a4539bd58ad9b0
child 421184 49ecacc9a7320bd8611e124e3c144e06387076c2
push id31309
push userbmo:gtatum@mozilla.com
push dateTue, 04 Oct 2016 20:35:38 +0000
reviewerstromey
bugs1307009
milestone52.0a1
Bug 1307009 - Restrict the CSS properties db test to only nightly; r?tromey The CSS properties DB breaks on uplift, and the only way to extract the information is through a full build. Since the DB is used only as a back-up if the CssPropertiesActor does not provide full information, it's ok to include experimental properties even in release. MozReview-Commit-ID: 7aDIsyZjf6h
devtools/shared/tests/unit/xpcshell.ini
--- a/devtools/shared/tests/unit/xpcshell.ini
+++ b/devtools/shared/tests/unit/xpcshell.ini
@@ -5,16 +5,21 @@ tail =
 firefox-appdir = browser
 skip-if = toolkit == 'android' || toolkit == 'gonk'
 support-files =
   exposeLoader.js
 
 [test_assert.js]
 [test_csslexer.js]
 [test_css-properties-db.js]
+# This test only enforces that the CSS database is up to date with nightly. The DB is
+# only used when inspecting a target that doesn't support the getCSSDatabase actor.
+# CSS properties are behind compile-time flags, and there is no automatic rebuild
+# process for uplifts, so this test breaks on uplift.
+run-if = nightly_build
 [test_fetch-bom.js]
 [test_fetch-chrome.js]
 [test_fetch-file.js]
 [test_fetch-http.js]
 [test_fetch-resource.js]
 [test_flatten.js]
 [test_indentation.js]
 [test_independent_loaders.js]