Bug 1176218 - p1. Constify nsContentTypeParser::Get... methods - r=froydnj draft
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 04 Oct 2016 16:19:15 +1100
changeset 421963 d07371c8cdcf116952bffafad0cd6cda78f59b20
parent 421960 4b9944879c9a60a9aba4a744a7401bc38e0f39c4
child 421964 12ba02f07106d2a9f2b85facad68c0fc6002f5a8
child 421994 823717a46e698342dce0f9e0b5bbfab21281297d
push id31645
push usergsquelart@mozilla.com
push dateFri, 07 Oct 2016 05:31:24 +0000
reviewersfroydnj
bugs1176218
milestone52.0a1
Bug 1176218 - p1. Constify nsContentTypeParser::Get... methods - r=froydnj GetType() and GetParameter() don't actually modify the nsContentTypeParser object, so we can make them const. It makes it possible to pass the parser as a const-ref, which I think makes sense as getters (even those doing some actual work) are usually const. MozReview-Commit-ID: 9vmqKbmt8y8
dom/base/nsContentTypeParser.h
dom/base/nsContentUtils.cpp
--- a/dom/base/nsContentTypeParser.h
+++ b/dom/base/nsContentTypeParser.h
@@ -11,18 +11,18 @@
 
 class nsIMIMEHeaderParam;
 
 class nsContentTypeParser {
 public:
   explicit nsContentTypeParser(const nsAString& aString);
   ~nsContentTypeParser();
 
-  nsresult GetParameter(const char* aParameterName, nsAString& aResult);
-  nsresult GetType(nsAString& aResult);
+  nsresult GetParameter(const char* aParameterName, nsAString& aResult) const;
+  nsresult GetType(nsAString& aResult) const;
 
 private:
   NS_ConvertUTF16toUTF8 mString;
   nsIMIMEHeaderParam*   mService;
 };
 
 #endif
 
--- a/dom/base/nsContentUtils.cpp
+++ b/dom/base/nsContentUtils.cpp
@@ -6123,26 +6123,27 @@ nsContentTypeParser::nsContentTypeParser
 }
 
 nsContentTypeParser::~nsContentTypeParser()
 {
   NS_IF_RELEASE(mService);
 }
 
 nsresult
-nsContentTypeParser::GetParameter(const char* aParameterName, nsAString& aResult)
+nsContentTypeParser::GetParameter(const char* aParameterName,
+                                  nsAString& aResult) const
 {
   NS_ENSURE_TRUE(mService, NS_ERROR_FAILURE);
   return mService->GetParameterHTTP(mString, aParameterName,
                                     EmptyCString(), false, nullptr,
                                     aResult);
 }
 
 nsresult
-nsContentTypeParser::GetType(nsAString& aResult)
+nsContentTypeParser::GetType(nsAString& aResult) const
 {
   nsresult rv = GetParameter(nullptr, aResult);
   NS_ENSURE_SUCCESS(rv, rv);
   nsContentUtils::ASCIIToLower(aResult);
   return NS_OK;
 }
 
 /* static */