Bug 1289249 - Set permissions of parent directory during --chown-recursive; r?dustin draft
authorGregory Szorc <gps@mozilla.com>
Thu, 29 Sep 2016 10:07:21 -0700
changeset 419529 c13957111f2bcdb77cf848f34dcebaa19e7dbff6
parent 419507 5ffed033557e5b6f9694123f1948f867f913ede3
child 419530 9b816b8883143db99041e6e3fbe1711a005a430c
push id30957
push userbmo:gps@mozilla.com
push dateFri, 30 Sep 2016 16:24:29 +0000
reviewersdustin
bugs1289249
milestone52.0a1
Bug 1289249 - Set permissions of parent directory during --chown-recursive; r?dustin os.walk() won't explicitly yield the root directory. So we need to update it explicitly when doing a recursive chown. MozReview-Commit-ID: JC0PNsk5gFK
testing/docker/recipes/run-task
--- a/testing/docker/recipes/run-task
+++ b/testing/docker/recipes/run-task
@@ -210,16 +210,19 @@ def main(args):
     for path in args.chown or []:
         print_line(b'chown', b'changing ownership of %s to %s:%s\n' % (
                    path, user.pw_name, group.gr_name))
         set_dir_permissions(path, uid, gid)
 
     for path in args.chown_recursive or []:
         print_line(b'chown', b'recursively changing ownership of %s to %s:%s\n' %
                    (path, user.pw_name, group.gr_name))
+
+        set_dir_permissions(path, uid, gid)
+
         for root, dirs, files in os.walk(path):
             for d in dirs:
                 set_dir_permissions(os.path.join(root, d), uid, gid)
 
             for f in files:
                 os.chown(os.path.join(root, f), uid, gid)
 
     checkout = args.vcs_checkout