Bug 1291971 - Part 4, enable controller startNewPresentation_error test. r=smaug. draft
authorShih-Chiang Chien <schien@mozilla.com>
Tue, 04 Oct 2016 09:00:10 +0200
changeset 430815 41fdcef117c34fe45588ee8f4f71f99ed2987748
parent 430814 65ed6e5c653530e2b4f8bb43628f3c60e7e997c4
child 430816 2b47a273aa9a4276aa24ae6ee10cb003b04417ba
push id33907
push userschien@mozilla.com
push dateFri, 28 Oct 2016 06:37:18 +0000
reviewerssmaug
bugs1291971
milestone52.0a1
Bug 1291971 - Part 4, enable controller startNewPresentation_error test. r=smaug. MozReview-Commit-ID: 51dfCphD0XJ
dom/presentation/PresentationService.cpp
testing/web-platform/meta/presentation-api/controlling-ua/startNewPresentation_error.html.ini
--- a/dom/presentation/PresentationService.cpp
+++ b/dom/presentation/PresentationService.cpp
@@ -637,17 +637,17 @@ PresentationService::StartSession(
                                   aCallback,
                                   aBuilderConstructor);
 
   if (aDeviceId.IsVoid()) {
     // Pop up a prompt and ask user to select a device.
     nsCOMPtr<nsIPresentationDevicePrompt> prompt =
       do_GetService(PRESENTATION_DEVICE_PROMPT_CONTRACTID);
     if (NS_WARN_IF(!prompt)) {
-      return aCallback->NotifyError(NS_ERROR_DOM_OPERATION_ERR);
+      return aCallback->NotifyError(NS_ERROR_DOM_INVALID_ACCESS_ERR);
     }
 
     nsresult rv = prompt->PromptDeviceSelection(request);
     if (NS_WARN_IF(NS_FAILED(rv))) {
       return aCallback->NotifyError(NS_ERROR_DOM_OPERATION_ERR);
     }
 
     return NS_OK;
--- a/testing/web-platform/meta/presentation-api/controlling-ua/startNewPresentation_error.html.ini
+++ b/testing/web-platform/meta/presentation-api/controlling-ua/startNewPresentation_error.html.ini
@@ -1,3 +1,6 @@
 [startNewPresentation_error.html]
   type: testharness
-  expected: ERROR
+  prefs: [dom.presentation.enabled: true,
+          dom.presentation.controller.enabled: true,
+          dom.presentation.discovery.enabled: true,
+          dom.presentation.device.name: "Firefox"]