Bug 1289249 - Use vendored tooltool in desktop-build image; r?dustin draft
authorGregory Szorc <gps@mozilla.com>
Wed, 28 Sep 2016 21:54:21 -0700
changeset 419533 356f94ba1879d0c40cb234500ef903c10eccbb31
parent 419532 e65be5b3f98fea300f4f13400e932fb4393a9df6
child 419534 5f397c7dbed70a4d0d81dd54eca008c9e3161c94
push id30957
push userbmo:gps@mozilla.com
push dateFri, 30 Sep 2016 16:24:29 +0000
reviewersdustin
bugs1289249
milestone52.0a1
Bug 1289249 - Use vendored tooltool in desktop-build image; r?dustin Vendoring: more reliable, more determinism, more secure. MozReview-Commit-ID: BYUUj4ZpndD
testing/docker/desktop-build/Dockerfile
--- a/testing/docker/desktop-build/Dockerfile
+++ b/testing/docker/desktop-build/Dockerfile
@@ -6,16 +6,19 @@ MAINTAINER    Dustin J. Mitchell <dustin
 VOLUME /home/worker/workspace
 VOLUME /home/worker/tooltool-cache
 
 # Add build scripts; these are the entry points from the taskcluster worker, and
 # operate on environment variables
 ADD             bin /home/worker/bin
 RUN             chmod +x /home/worker/bin/*
 
+# %include testing/docker/recipes/tooltool.py
+ADD topsrcdir/testing/docker/recipes/tooltool.py /builds/tooltool.py
+
 # Add wrapper scripts for xvfb allowing tasks to easily retry starting up xvfb
 # %include testing/docker/recipes/xvfb.sh
 ADD topsrcdir/testing/docker/recipes/xvfb.sh /home/worker/scripts/xvfb.sh
 
 # Add configuration
 COPY            dot-config                    /home/worker/.config
 
 # Generate machine uuid file
@@ -27,20 +30,15 @@ RUN dbus-uuidgen --ensure=/var/lib/dbus/
 # mozharness is run (not its --work-dir).  See Bug 1169652.
 ADD           oauth.txt /home/worker/
 
 # stubbed out buildprops, which keeps mozharness from choking
 # Note that this needs to be in the parent of the workspace directory and in
 # the directory where mozharness is run (not its --work-dir)
 ADD           buildprops.json /home/worker/
 
-# install tooltool directly from github where tooltool_wrapper.sh et al. expect
-# to find it
-RUN wget -O /builds/tooltool.py https://raw.githubusercontent.com/mozilla/build-tooltool/master/tooltool.py
-RUN chmod +x /builds/tooltool.py
-
 # Move installation to base centos6-build image once Bug 1272629 is fixed
 # Install the screen package here to use with xvfb.
 # Install bison to build binutils.
 RUN yum install -y bison screen
 
 # Set a default command useful for debugging
 CMD ["/bin/bash", "--login"]