Bug 1305877 - Change WPT chunking default to directory hash; r?jgraham draft
authorGregory Szorc <gps@mozilla.com>
Fri, 30 Sep 2016 20:40:03 -0700
changeset 420705 519bfe64a1ba96a845c633f50e530a27191bac43
parent 420704 c9311e759dd59577a0618539088cecc6f51cfd89
child 420706 8e7941c371fd11615e2ab79739d84a6a3a5fe097
child 420747 342038186034d6c5080771bd6661eeb5d9369d50
child 420748 c9f5b5b4a7fd73a5a98eb91b6a4b4192471d7b59
push id31265
push usergszorc@mozilla.com
push dateTue, 04 Oct 2016 13:32:17 +0000
reviewersjgraham
bugs1305877
milestone52.0a1
Bug 1305877 - Change WPT chunking default to directory hash; r?jgraham Before this, the default of "equal_time" resulted in W7 jobs on Windows debug builds executing over 6 times slower than the shortest chunk. Chunking by hash of test directory makes the chunk sizes more consistent. They aren't as consistent as a full path hashing or random chunking. But it is an improvement. MozReview-Commit-ID: 7bUSxY8GhH7
testing/web-platform/harness/wptrunner/wptcommandline.py
--- a/testing/web-platform/harness/wptrunner/wptcommandline.py
+++ b/testing/web-platform/harness/wptrunner/wptcommandline.py
@@ -292,17 +292,17 @@ def check_args(kwargs):
     if kwargs["run_info"] is None:
         kwargs["run_info"] = kwargs["config_path"]
 
     if kwargs["this_chunk"] > 1:
         require_arg(kwargs, "total_chunks", lambda x: x >= kwargs["this_chunk"])
 
     if kwargs["chunk_type"] is None:
         if kwargs["total_chunks"] > 1:
-            kwargs["chunk_type"] = "equal_time"
+            kwargs["chunk_type"] = "dir_hash"
         else:
             kwargs["chunk_type"] = "none"
 
     if kwargs["processes"] is None:
         kwargs["processes"] = 1
 
     if kwargs["debugger"] is not None:
         import mozdebug