Bug 1266134 - Fix responsive design possible leak on shutdown. r=jryans draft
authorAlexandre Poirot <poirot.alex@gmail.com>
Thu, 15 Sep 2016 09:57:46 -0700
changeset 422065 52f8099ede88cf4ee950a20a93230845cfc5a6a9
parent 422064 ef039b97b009afffc3fe66f9af54bafa0bcf2fc7
child 422066 79ac007e64e1fc5ee66fee623973196f29c6885b
push id31675
push userbmo:poirot.alex@gmail.com
push dateFri, 07 Oct 2016 09:37:23 +0000
reviewersjryans
bugs1266134
milestone52.0a1
Bug 1266134 - Fix responsive design possible leak on shutdown. r=jryans MozReview-Commit-ID: 3DteAYhBDNi
devtools/client/responsivedesign/resize-commands.js
--- a/devtools/client/responsivedesign/resize-commands.js
+++ b/devtools/client/responsivedesign/resize-commands.js
@@ -54,20 +54,19 @@ exports.items = [
       },
       onChange: function (aTarget, aChangeHandler) {
         if (aTarget.tab) {
           ResponsiveUIManager.on("on", aChangeHandler);
           ResponsiveUIManager.on("off", aChangeHandler);
         }
       },
       offChange: function (aTarget, aChangeHandler) {
-        if (aTarget.tab) {
-          ResponsiveUIManager.off("on", aChangeHandler);
-          ResponsiveUIManager.off("off", aChangeHandler);
-        }
+        // Do not check for target.tab as it may already be null during destroy
+        ResponsiveUIManager.off("on", aChangeHandler);
+        ResponsiveUIManager.off("off", aChangeHandler);
       },
     },
     exec: gcli_cmd_resize
   },
   {
     item: "command",
     runAt: "client",
     name: "resize to",