Bug 1123972 - Up search geo timeout to 3 seconds. r?florian draft
authorMichael Kaply <mozilla@kaply.com>
Fri, 23 Sep 2016 15:33:58 -0500
changeset 417291 47547621c2f73bdacad43a7a88dd7fa1c72c5330
parent 417290 f3800637757590adbf18a09c18b9351a2d04fa76
child 532058 e42d03826100054a6bf0236d6a637d07e38640bf
push id30367
push usermozilla@kaply.com
push dateFri, 23 Sep 2016 20:36:37 +0000
reviewersflorian
bugs1123972
milestone52.0a1
Bug 1123972 - Up search geo timeout to 3 seconds. r?florian MozReview-Commit-ID: 71olvznwLrr
modules/libpref/init/all.js
toolkit/components/search/tests/xpcshell/head_search.js
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -5356,19 +5356,17 @@ pref("browser.search.log", false);
 pref("browser.search.update", true);
 pref("browser.search.update.log", false);
 pref("browser.search.update.interval", 21600);
 pref("browser.search.suggest.enabled", true);
 pref("browser.search.reset.enabled", false);
 pref("browser.search.reset.whitelist", "");
 pref("browser.search.geoSpecificDefaults", false);
 pref("browser.search.geoip.url", "https://location.services.mozilla.com/v1/country?key=%MOZILLA_API_KEY%");
-// NOTE: this timeout figure is also the "high" value for the telemetry probe
-// SEARCH_SERVICE_COUNTRY_FETCH_MS - if you change this also change that probe.
-pref("browser.search.geoip.timeout", 2000);
+pref("browser.search.geoip.timeout", 3000);
 
 #ifdef MOZ_OFFICIAL_BRANDING
 // {moz:official} expands to "official"
 pref("browser.search.official", true);
 #endif
 
 #ifndef MOZ_WIDGET_GONK
 // GMPInstallManager prefs
--- a/toolkit/components/search/tests/xpcshell/head_search.js
+++ b/toolkit/components/search/tests/xpcshell/head_search.js
@@ -339,17 +339,17 @@ function isSubObjectOf(expectedObj, actu
 // doesn't run in child processes anyways.
 if (!isChild) {
   // Expand the amount of information available in error logs
   Services.prefs.setBoolPref("browser.search.log", true);
 
   // The geo-specific search tests assume certain prefs are already setup, which
   // might not be true when run in comm-central etc.  So create them here.
   Services.prefs.setBoolPref("browser.search.geoSpecificDefaults", true);
-  Services.prefs.setIntPref("browser.search.geoip.timeout", 2000);
+  Services.prefs.setIntPref("browser.search.geoip.timeout", 3000);
   // But still disable geoip lookups - tests that need it will re-configure this.
   Services.prefs.setCharPref("browser.search.geoip.url", "");
   // Also disable region defaults - tests using it will also re-configure it.
   Services.prefs.getDefaultBranch(BROWSER_SEARCH_PREF).setCharPref("geoSpecificDefaults.url", "");
 }
 
 /**
  * After useHttpServer() is called, this string contains the URL of the "data"