Bug 1303668 - Failing to find a symbols url should be a warning instead of a exception. r=whimboo draft
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Fri, 23 Sep 2016 13:53:30 -0400
changeset 419005 99ff82ffca6eed209ce6fd31ab747239d7100516
parent 418992 f7d5008ee2ab9200052e45ad6ecc3f3a348f7f86
child 532464 1c2a3bfa0212f276aea9d354f74d51e44d8efea0
push id30815
push userarmenzg@mozilla.com
push dateThu, 29 Sep 2016 12:37:23 +0000
reviewerswhimboo
bugs1303668
milestone52.0a1
Bug 1303668 - Failing to find a symbols url should be a warning instead of a exception. r=whimboo Failing to find symbols in this case should be turned into a warning rather than dumping the traceback since we're going to rely on mozcrash doing the right thing later on. This will reduce unnecessary reporting of symbols not being available. MozReview-Commit-ID: GXO01B7vzGV
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -195,17 +195,17 @@ class TestingMixin(VirtualenvMixin, Buil
             symbols_url = self.query_prefixed_build_dir_url('.crashreporter-symbols.zip')
 
             # Check if the URL exists. If not, use none to allow mozcrash to auto-check for symbols
             try:
                 if symbols_url:
                     self._urlopen(symbols_url, timeout=120)
                     self.symbols_url = symbols_url
             except (urllib2.HTTPError, urllib2.URLError, socket.error, socket.timeout):
-                self.exception("Can't figure out symbols_url from installer_url: %s!" % self.installer_url, level=WARNING)
+                self.warning("Can't figure out symbols_url from installer_url: %s!" % self.installer_url)
 
         # If no symbols URL can be determined let minidump_stackwalk query the symbols.
         # As of now this only works for Nightly and release builds.
         if not self.symbols_url:
             self.warning("No symbols_url found. Let minidump_stackwalk query for symbols.")
 
         return self.symbols_url