Bug 1301675 - Received tracks from RTCPeerConnection are stoppable. r?jib
MozReview-Commit-ID: L8ag0BEWL39
--- a/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h
+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h
@@ -169,18 +169,18 @@ public:
}
already_AddRefed<PledgeVoid>
ApplyConstraints(nsPIDOMWindowInner* aWindow,
const dom::MediaTrackConstraints& aConstraints) override;
void Stop() override
{
- // XXX Fix in later patch.
- NS_ERROR("Can't stop a remote source!");
+ // XXX (Bug 1314270): Implement rejection logic if necessary when we have
+ // clarity in the spec.
}
void SetPrincipal(nsIPrincipal* aPrincipal)
{
mPrincipal = aPrincipal;
PrincipalChanged();
}
@@ -223,22 +223,16 @@ class RemoteSourceStreamInfo : public So
return TRACK_INVALID;
}
return track->mTrackID;
}
void StartReceiving();
private:
-#if !defined(MOZILLA_EXTERNAL_LINKAGE)
- // MediaStreamTrackSources associated with this remote stream.
- // We use them for updating their principal if that's needed.
- std::vector<RefPtr<RemoteTrackSource>> mTrackSources;
-#endif
-
// True iff SetPullEnabled(true) has been called on the DOMMediaStream. This
// happens when offer/answer concludes.
bool mReceiving;
};
class PeerConnectionMedia : public sigslot::has_slots<> {
~PeerConnectionMedia()
{