Bug 1301675 - Received tracks from RTCPeerConnection are stoppable. r?jib draft
authorAndreas Pehrson <pehrsons@gmail.com>
Fri, 16 Sep 2016 15:18:09 +0200
changeset 432223 4e34991643cc47049aa501bcd4476785b0d43f81
parent 432222 07ee983c15074517fdadcda54f4bcae827f87b6f
child 432224 6f5dceb22005c3668a8ed6fa9dd8dde3304fd47b
push id34235
push userbmo:pehrson@telenordigital.com
push dateTue, 01 Nov 2016 13:40:03 +0000
reviewersjib
bugs1301675
milestone52.0a1
Bug 1301675 - Received tracks from RTCPeerConnection are stoppable. r?jib MozReview-Commit-ID: L8ag0BEWL39
media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h
--- a/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h
+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h
@@ -169,18 +169,18 @@ public:
   }
 
   already_AddRefed<PledgeVoid>
   ApplyConstraints(nsPIDOMWindowInner* aWindow,
                    const dom::MediaTrackConstraints& aConstraints) override;
 
   void Stop() override
   {
-    // XXX Fix in later patch.
-    NS_ERROR("Can't stop a remote source!");
+    // XXX (Bug 1314270): Implement rejection logic if necessary when we have
+    //                    clarity in the spec.
   }
 
   void SetPrincipal(nsIPrincipal* aPrincipal)
   {
     mPrincipal = aPrincipal;
     PrincipalChanged();
   }
 
@@ -223,22 +223,16 @@ class RemoteSourceStreamInfo : public So
       return TRACK_INVALID;
     }
     return track->mTrackID;
   }
 
   void StartReceiving();
 
  private:
-#if !defined(MOZILLA_EXTERNAL_LINKAGE)
-  // MediaStreamTrackSources associated with this remote stream.
-  // We use them for updating their principal if that's needed.
-  std::vector<RefPtr<RemoteTrackSource>> mTrackSources;
-#endif
-
   // True iff SetPullEnabled(true) has been called on the DOMMediaStream. This
   // happens when offer/answer concludes.
   bool mReceiving;
 };
 
 class PeerConnectionMedia : public sigslot::has_slots<> {
   ~PeerConnectionMedia()
   {