Backport fix for 'Loading...' indicator being displayed instead of 'Saving...' (
bug 1288109) r?davidwalsh
Upstream Review Board silently fixed this when rewriting apiUtils for ES6.
https://github.com/reviewboard/reviewboard/blob/1ddc830980/reviewboard/static/rb/js/utils/apiUtils.es6.js#L26
MozReview-Commit-ID: AZvujOxQ3pr
--- a/reviewboard/reviewboard/static/rb/js/utils/apiUtils.js
+++ b/reviewboard/reviewboard/static/rb/js/utils/apiUtils.js
@@ -11,17 +11,17 @@
*/
RB.setActivityIndicator = function(status, options) {
var $activityIndicator = $("#activity-indicator"),
$indicatorText = $activityIndicator.children('.indicator-text');
if (status) {
if (RB.ajaxOptions.enableIndicator && !options.noActivityIndicator) {
$indicatorText
- .text((options.type || options.type === "GET")
+ .text((options.type && options.type === "GET")
? gettext("Loading...") : gettext("Saving..."));
$activityIndicator
.removeClass("error")
.show();
}
} else if (RB.ajaxOptions.enableIndicator &&
!options.noActivityIndicator &&