Bug 1304457 - Add some missing mCanSend checks. r?dvander draft
authorKartikaya Gupta <kgupta@mozilla.com>
Wed, 21 Sep 2016 13:51:23 -0400
changeset 416220 708be6822a78de646fc3a4a22b0254d36c8a4358
parent 416219 001ddb20684422a1177172e49efbdd599bb5469c
child 531782 128a9943a2b72ad025a825d23928901088a0a623
push id30064
push userkgupta@mozilla.com
push dateWed, 21 Sep 2016 17:52:14 +0000
reviewersdvander
bugs1304457
milestone52.0a1
Bug 1304457 - Add some missing mCanSend checks. r?dvander MozReview-Commit-ID: Jctjbgilu5z
gfx/layers/ipc/RemoteContentController.cpp
--- a/gfx/layers/ipc/RemoteContentController.cpp
+++ b/gfx/layers/ipc/RemoteContentController.cpp
@@ -132,42 +132,48 @@ RemoteContentController::UpdateOverscrol
 {
   if (MessageLoop::current() != mCompositorThread) {
     mCompositorThread->PostTask(NewRunnableMethod<float,
                                         float, bool>(this,
                                              &RemoteContentController::UpdateOverscrollVelocity,
                                              aX, aY, aIsRootContent));
     return;
   }
-  Unused << SendUpdateOverscrollVelocity(aX, aY, aIsRootContent);
+  if (mCanSend) {
+    Unused << SendUpdateOverscrollVelocity(aX, aY, aIsRootContent);
+  }
 }
 
 void
 RemoteContentController::UpdateOverscrollOffset(float aX, float aY, bool aIsRootContent)
 {
   if (MessageLoop::current() != mCompositorThread) {
     mCompositorThread->PostTask(NewRunnableMethod<float,
                                         float, bool>(this,
                                              &RemoteContentController::UpdateOverscrollOffset,
                                              aX, aY, aIsRootContent));
     return;
   }
-  Unused << SendUpdateOverscrollOffset(aX, aY, aIsRootContent);
+  if (mCanSend) {
+    Unused << SendUpdateOverscrollOffset(aX, aY, aIsRootContent);
+  }
 }
 
 void
 RemoteContentController::SetScrollingRootContent(bool aIsRootContent)
 {
   if (MessageLoop::current() != mCompositorThread) {
     mCompositorThread->PostTask(NewRunnableMethod<bool>(this,
                                              &RemoteContentController::SetScrollingRootContent,
                                              aIsRootContent));
     return;
   }
-  Unused << SendSetScrollingRootContent(aIsRootContent);
+  if (mCanSend) {
+    Unused << SendSetScrollingRootContent(aIsRootContent);
+  }
 }
 
 void
 RemoteContentController::NotifyMozMouseScrollEvent(const FrameMetrics::ViewID& aScrollId,
                                                    const nsString& aEvent)
 {
   if (MessageLoop::current() != mCompositorThread) {
     // We have to send messages from the compositor thread