Bug 1130447 - Hide the password manager timeLastUsed column by default. r=MattN draft
authorFischer.json <fischer.json@gmail.com>
Tue, 20 Sep 2016 15:45:15 +0800
changeset 420027 d2307d081ea8ae39e25c0736ee87b34debd11e01
parent 419914 7c576fe3279d87543f0a03b844eba7bc215e17f1
child 532701 91635f1fe947d04bf71fd21f12b4d7af512cd8d8
push id31071
push userbmo:fliu@mozilla.com
push dateMon, 03 Oct 2016 06:57:43 +0000
reviewersMattN
bugs1130447
milestone52.0a1
Bug 1130447 - Hide the password manager timeLastUsed column by default. r=MattN MozReview-Commit-ID: LxKnIfBhtQh
toolkit/components/passwordmgr/content/passwordManager.xul
toolkit/components/passwordmgr/test/browser/browser_passwordmgr_fields.js
--- a/toolkit/components/passwordmgr/content/passwordManager.xul
+++ b/toolkit/components/passwordmgr/content/passwordManager.xul
@@ -9,16 +9,17 @@
 <!DOCTYPE dialog SYSTEM "chrome://passwordmgr/locale/passwordManager.dtd" >
 
 <window id="SignonViewerDialog"
         windowtype="Toolkit:PasswordManager"
         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
         onload="Startup();"
         onunload="Shutdown();"
         title="&savedLogins.title;"
+        style="width: 45em;"
         persist="width height screenX screenY">
 
   <script type="application/javascript" src="chrome://passwordmgr/content/passwordManager.js"/>
 
   <stringbundle id="signonBundle"
                 src="chrome://passwordmgr/locale/passwordmgr.properties"/>
 
   <keyset>
@@ -85,17 +86,18 @@
                  data-field-name="password" persist="width"
                  hidden="true"/>
         <splitter class="tree-splitter"/>
         <treecol id="timeCreatedCol" label="&treehead.timeCreated.label;" flex="10"
                  data-field-name="timeCreated" persist="width hidden"
                  hidden="true"/>
         <splitter class="tree-splitter"/>
         <treecol id="timeLastUsedCol" label="&treehead.timeLastUsed.label;" flex="20"
-                 data-field-name="timeLastUsed" persist="width hidden"/>
+                 data-field-name="timeLastUsed" persist="width hidden"
+                 hidden="true"/>
         <splitter class="tree-splitter"/>
         <treecol id="timePasswordChangedCol" label="&treehead.timePasswordChanged.label;" flex="10"
                  data-field-name="timePasswordChanged" persist="width hidden"/>
         <splitter class="tree-splitter"/>
         <treecol id="timesUsedCol" label="&treehead.timesUsed.label;" flex="1"
                  data-field-name="timesUsed" persist="width hidden"
                  hidden="true"/>
         <splitter class="tree-splitter"/>
--- a/toolkit/components/passwordmgr/test/browser/browser_passwordmgr_fields.js
+++ b/toolkit/components/passwordmgr/test/browser/browser_passwordmgr_fields.js
@@ -36,18 +36,18 @@ function test() {
        "Correct user saved");
 
     let timeCreatedCol = doc.getElementById("timeCreatedCol");
     is(timeCreatedCol.getAttribute("hidden"), "true",
        "Time created column is not displayed");
 
 
     let timeLastUsedCol = doc.getElementById("timeLastUsedCol");
-    is(timeLastUsedCol.getAttribute("hidden"), "",
-       "Last Used column is displayed");
+    is(timeLastUsedCol.getAttribute("hidden"), "true",
+       "Last Used column is not displayed");
 
     let timePasswordChangedCol = doc.getElementById("timePasswordChangedCol");
     is(timePasswordChangedCol.getAttribute("hidden"), "",
        "Last Changed column is displayed");
 
     // cleanup
     Services.ww.registerNotification(function (aSubject, aTopic, aData) {
       if (aSubject.location == pwmgrdlg.location && aTopic == "domwindowclosed") {