Bug 1303673: P5. Provide warning when a MediaDataDecoder error occurs. r?cpearce draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Tue, 20 Sep 2016 15:59:42 +1000
changeset 415427 571f59e8fe1d3a142ea5aa8a38aec7340d3d34d0
parent 415426 ad8a6ecb54e0f9331b5d6f1af191702b80eef511
child 415428 4f0e19a0833643b5b6bf9e20b65903e0bf99d270
push id29868
push userbmo:jyavenard@mozilla.com
push dateTue, 20 Sep 2016 09:26:58 +0000
reviewerscpearce
bugs1303673
milestone52.0a1
Bug 1303673: P5. Provide warning when a MediaDataDecoder error occurs. r?cpearce Warnings were provided earlier on and got removed. So we instead make it consistent across all decoders. MozReview-Commit-ID: 53obtEClq98
dom/media/MediaFormatReader.cpp
--- a/dom/media/MediaFormatReader.cpp
+++ b/dom/media/MediaFormatReader.cpp
@@ -715,16 +715,17 @@ MediaFormatReader::NotifyDrainComplete(T
   decoder.mDrainComplete = true;
   ScheduleUpdate(aTrack);
 }
 
 void
 MediaFormatReader::NotifyError(TrackType aTrack, const MediaResult& aError)
 {
   MOZ_ASSERT(OnTaskQueue());
+  NS_WARNING(aError.Description().get());
   LOGV("%s Decoding error", TrackTypeToStr(aTrack));
   auto& decoder = GetDecoderData(aTrack);
   decoder.mError = decoder.HasFatalError() ? decoder.mError : Some(aError);
   ScheduleUpdate(aTrack);
 }
 
 void
 MediaFormatReader::NotifyWaitingForData(TrackType aTrack)