Bug 1303879 - Use explicit ctors. - r=mtseng draft
authorJeff Gilbert <jgilbert@mozilla.com>
Thu, 01 Sep 2016 17:51:08 -0700
changeset 415744 7970e8fccc1756b7afff4a5a35baddd4245b34b4
parent 415743 4f35f8de28e20d45283fd8712150c8ed28976ab0
child 415745 8b43f584f629e8227788c909f7c5b00d5c28e19e
push id29953
push userbmo:jgilbert@mozilla.com
push dateTue, 20 Sep 2016 23:29:17 +0000
reviewersmtseng
bugs1303879
milestone51.0a1
Bug 1303879 - Use explicit ctors. - r=mtseng MozReview-Commit-ID: Hs4V81pFAc8
dom/canvas/WebGLFramebuffer.cpp
dom/canvas/WebGLFramebuffer.h
--- a/dom/canvas/WebGLFramebuffer.cpp
+++ b/dom/canvas/WebGLFramebuffer.cpp
@@ -1075,25 +1075,25 @@ WebGLFramebuffer::ResolvedData::Resolved
     ////
 
     const auto fnColor = [&](const WebGLFBAttachPoint& attach,
                              decltype(drawSet)* const out_destSet)
     {
         if (!fnCommon(attach))
             return;
 
-        out_destSet->insert(attach);
+        out_destSet->insert(WebGLFBAttachPoint::Ordered(attach));
     };
 
     const auto fnDepthStencil = [&](const WebGLFBAttachPoint& attach) {
         if (!fnCommon(attach))
             return;
 
-        drawSet.insert(attach);
-        readSet.insert(attach);
+        drawSet.insert(WebGLFBAttachPoint::Ordered(attach));
+        readSet.insert(WebGLFBAttachPoint::Ordered(attach));
     };
 
     ////
 
     fnDepthStencil(parent.mDepthAttachment);
     fnDepthStencil(parent.mStencilAttachment);
     fnDepthStencil(parent.mDepthStencilAttachment);
 
--- a/dom/canvas/WebGLFramebuffer.h
+++ b/dom/canvas/WebGLFramebuffer.h
@@ -102,17 +102,17 @@ public:
 
     void OnBackingStoreRespecified() const;
 
     ////
 
     struct Ordered {
         const WebGLFBAttachPoint& mRef;
 
-        Ordered(const WebGLFBAttachPoint& ref)
+        explicit Ordered(const WebGLFBAttachPoint& ref)
             : mRef(ref)
         { }
 
         bool operator<(const Ordered& other) const {
             MOZ_ASSERT(mRef.IsDefined() && other.mRef.IsDefined());
 
 #define ORDER_BY(X) if (X != other.X) return X < other.X;
 
@@ -177,17 +177,17 @@ protected:
         const WebGLFBAttachPoint* depthBuffer;
         const WebGLFBAttachPoint* stencilBuffer;
 
         // IsFeedback
         std::vector<const WebGLFBAttachPoint*> texDrawBuffers; // Non-null
         std::set<WebGLFBAttachPoint::Ordered> drawSet;
         std::set<WebGLFBAttachPoint::Ordered> readSet;
 
-        ResolvedData(const WebGLFramebuffer& parent);
+        explicit ResolvedData(const WebGLFramebuffer& parent);
     };
 
     UniquePtr<const ResolvedData> mResolvedCompleteData;
 
     ////
 
 public:
     NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(WebGLFramebuffer)