Bug 1208316 - HTMLMediaElement.ended should follow MediaStream.active. r?jib draft
authorAndreas Pehrson <pehrsons@gmail.com>
Wed, 14 Sep 2016 10:02:23 +0200
changeset 432209 02c1dc36a03f05ae8fcba2a8674308ec01d45b65
parent 432208 d3c5f3d3e787c184630841e57390833b019f7265
child 432210 ab298de858ac460986717d88485189283a441720
push id34233
push userbmo:pehrson@telenordigital.com
push dateTue, 01 Nov 2016 13:21:40 +0000
reviewersjib
bugs1208316
milestone52.0a1
Bug 1208316 - HTMLMediaElement.ended should follow MediaStream.active. r?jib MozReview-Commit-ID: CIJZz5khY8R
dom/html/HTMLMediaElement.cpp
--- a/dom/html/HTMLMediaElement.cpp
+++ b/dom/html/HTMLMediaElement.cpp
@@ -863,21 +863,18 @@ NS_IMETHODIMP HTMLMediaElement::GetMozAu
   *aAutoplayEnabled = mAutoplayEnabled;
 
   return NS_OK;
 }
 
 bool
 HTMLMediaElement::Ended()
 {
-  if (MediaStream* stream = GetSrcMediaStream()) {
-    return stream->IsFinished();
-  }
-
-  return mDecoder && mDecoder->IsEnded();
+  return (mDecoder && mDecoder->IsEnded()) ||
+         (mSrcStream && !mSrcStream->Active());
 }
 
 NS_IMETHODIMP HTMLMediaElement::GetEnded(bool* aEnded)
 {
   *aEnded = Ended();
   return NS_OK;
 }