Bug 1299072: P5. Don't rely on specific error to assess recoverability. r?cpearce draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Sat, 10 Sep 2016 10:49:54 +1000
changeset 412870 3be51f71e4ac8e15d05a567ff932bf3f6ff6a043
parent 412869 298a7d07a7fb71102ffd71c71e9eeed69776ac27
child 412871 6c12c60923f2fe4299fe53902ba00add3d834c92
push id29276
push userbmo:jyavenard@mozilla.com
push dateTue, 13 Sep 2016 03:29:20 +0000
reviewerscpearce
bugs1299072
milestone51.0a1
Bug 1299072: P5. Don't rely on specific error to assess recoverability. r?cpearce MozReview-Commit-ID: KSmW2TEBO9y
dom/media/MediaFormatReader.cpp
--- a/dom/media/MediaFormatReader.cpp
+++ b/dom/media/MediaFormatReader.cpp
@@ -1247,18 +1247,17 @@ MediaFormatReader::Update(TrackType aTra
     }
   }
 
   if (decoder.mNeedDraining) {
     DrainDecoder(aTrack);
     return;
   }
 
-  if (decoder.mError &&
-      decoder.mError.ref().Code() == NS_ERROR_DOM_MEDIA_DECODE_ERR) {
+  if (decoder.mError && !decoder.HasFatalError()) {
     decoder.mDecodePending = false;
     decoder.mError.reset();
     if (++decoder.mNumOfConsecutiveError > decoder.mMaxConsecutiveError) {
       NotifyError(aTrack);
       return;
     }
     LOG("%s decoded error count %d", TrackTypeToStr(aTrack),
                                      decoder.mNumOfConsecutiveError);