Bug 1241719 - Fix intermittent browser_ext_tabs_onUpdated.js draft
authorRob Wu <rob@robwu.nl>
Sat, 10 Sep 2016 03:16:39 -0700
changeset 412351 2352ee7a0107b35d9d54fe96b03ed80a5aea0e5c
parent 410066 8c9c4e816e86f903c1d820f3f29715dc070a5a4a
child 530968 6c142e7bcfecbb0ff91765b4c5449ff1f3a72648
push id29154
push userbmo:rob@robwu.nl
push dateSat, 10 Sep 2016 10:17:25 +0000
bugs1241719
milestone51.0a1
Bug 1241719 - Fix intermittent browser_ext_tabs_onUpdated.js MozReview-Commit-ID: LhHS6F0YFUJ
browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js
--- a/browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js
+++ b/browser/components/extensions/test/browser/browser_ext_tabs_onUpdated.js
@@ -25,17 +25,21 @@ add_task(function* () {
       let expectedSequence = [
         {status: "loading"},
         {status: "loading", url: pageURL},
         {status: "complete"},
       ];
       let collectedSequence = [];
 
       browser.tabs.onUpdated.addListener(function(tabId, updatedInfo) {
-        collectedSequence.push(updatedInfo);
+        // onUpdated also fires with updatedInfo.faviconUrl, so explicitly
+        // check for updatedInfo.status before recording the event.
+        if ("status" in updatedInfo) {
+          collectedSequence.push(updatedInfo);
+        }
       });
 
       browser.runtime.onMessage.addListener(function() {
         if (collectedSequence.length !== expectedSequence.length) {
           browser.test.assertEq(
             JSON.stringify(expectedSequence),
             JSON.stringify(collectedSequence),
             "got unexpected number of updateInfo data"