Bug 1298449 - Add hover effect to the zoom indicator in the location bar r=dao draft
authorMatthew Wein <mwein@mozilla.com>
Thu, 08 Sep 2016 14:48:14 +0100
changeset 411721 f3c976ffe33c4ac6280d71eb958e0c2ad380c209
parent 411705 a3a5d19b2d0539c66e787e0f2f86c539fb1f6fd8
child 530793 10c2a63fc7d70687813697943a1e19dd4623f55f
push id28962
push usermwein@mozilla.com
push dateThu, 08 Sep 2016 14:24:57 +0000
reviewersdao
bugs1298449
milestone51.0a1
Bug 1298449 - Add hover effect to the zoom indicator in the location bar r=dao For the :hover state, I used the background color that was currently being used for the :active state. For the :active state, I bumped up the alpha from .1 to .15 to make it darker, and checked that it passes the WCAG tests. MozReview-Commit-ID: DLeSf6XAmhp
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/windows/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -972,18 +972,22 @@ toolbaritem[cui-areatype="menu-panel"] >
   border: 1px solid ThreeDLightShadow;
 }
 
 #urlbar-zoom-button[animate="true"] {
   animation-name: urlbar-zoom-reset-pulse;
   animation-duration: 250ms;
 }
 
+#urlbar-zoom-button:hover {
+  background-color: hsla(0,0%,0%,.1);
+}
+
 #urlbar-zoom-button:hover:active {
-  background-color: hsla(0,0%,0%,.1);
+  background-color: hsla(0,0%,0%,.15);
 }
 
 #urlbar-zoom-button > .toolbarbutton-text {
   display: -moz-box;
 }
 
 #urlbar-zoom-button > .toolbarbutton-icon {
   display: none;
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -1684,18 +1684,23 @@ toolbar .toolbarbutton-1 > .toolbarbutto
   background-color: hsla(0,0%,0%,.05);
   border: 1px solid hsla(0,0%,0%,.1);
 }
 
 #urlbar-zoom-button[animate="true"] {
   animation-name: urlbar-zoom-reset-pulse;
   animation-duration: 250ms;
 }
+
+#urlbar-zoom-button:hover {
+  background-color: hsla(0,0%,0%,.1);
+}
+
 #urlbar-zoom-button:hover:active {
-  background-color: hsla(0,0%,0%,.1);
+  background-color: hsla(0,0%,0%,.15);
 }
 
 #urlbar-zoom-button > .toolbarbutton-text {
   display: -moz-box;
 }
 
 #urlbar-zoom-button > .toolbarbutton-icon {
   display: none;
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1417,18 +1417,22 @@ html|*.urlbar-input:-moz-lwtheme::placeh
   border: 1px solid ThreeDLightShadow;
 }
 
 #urlbar-zoom-button[animate="true"] {
   animation-name: urlbar-zoom-reset-pulse;
   animation-duration: 250ms;
 }
 
+#urlbar-zoom-button:hover {
+  background-color: hsla(0,0%,0%,.1);
+}
+
 #urlbar-zoom-button:hover:active {
-  background-color: hsla(0,0%,0%,.1);
+  background-color: hsla(0,0%,0%,.15);
 }
 
 #urlbar-zoom-button > .toolbarbutton-text {
   display: -moz-box;
 }
 
 #urlbar-zoom-button > .toolbarbutton-icon {
   display: none;