Bug 1286075: do not use secrets for hazard jobs; r=sfink draft
authorDustin J. Mitchell <dustin@mozilla.com>
Wed, 07 Sep 2016 15:58:29 +0000
changeset 412759 d64a6c726654d5cbcb0ceb5423a59298099d8120
parent 412758 e53ff601424b37363fa47d20e4ae8e850e0d30b9
child 412760 3018db036f1d5ebbbd42cba66ee74ed3dfd82a0e
push id29252
push userdmitchell@mozilla.com
push dateMon, 12 Sep 2016 19:16:39 +0000
reviewerssfink
bugs1286075
milestone51.0a1
Bug 1286075: do not use secrets for hazard jobs; r=sfink Secrets are accessed via http://taskcluster/secrets, and the hazard scripts show no evidence of such calls. MozReview-Commit-ID: 6xp6D2ybwap
taskcluster/ci/hazard/kind.yml
--- a/taskcluster/ci/hazard/kind.yml
+++ b/taskcluster/ci/hazard/kind.yml
@@ -28,17 +28,16 @@ jobs:
                 gecko-v1: shell-haz.debug
                 gecko-v2: shell-haz-debug
         treeherder:
             platform: linux64/debug
             symbol: SM-tc(H)
         run:
             using: hazard
             tooltool-manifest: "browser/config/tooltool-manifests/linux64/hazard.manifest"
-            secrets: true  # TODO(taskdiff): don't use secrets for these jobs
             command: >
                 tc-vcs checkout workspace/gecko "$GECKO_BASE_REPOSITORY" "$GECKO_HEAD_REPOSITORY" "$GECKO_HEAD_REV" "$GECKO_HEAD_REF"
                 && cd ./workspace/gecko/taskcluster/scripts/builder
                 && ./build-haz-linux.sh --project shell $HOME/workspace
         run-on-projects:
             - integration
             - release
         when:
@@ -55,17 +54,16 @@ jobs:
                 gecko-v2: browser-haz-debug
         treeherder:
             platform: linux64/debug
             symbol: tc(H)
         run:
             using: hazard
             tooltool-manifest: "browser/config/tooltool-manifests/linux64/hazard.manifest"
             mozconfig: "browser/config/mozconfigs/linux64/hazards"
-            secrets: true  # TODO(taskdiff): don't use secrets for these jobs
             command: >
                 tc-vcs checkout workspace/gecko "$GECKO_BASE_REPOSITORY" "$GECKO_HEAD_REPOSITORY" "$GECKO_HEAD_REV" "$GECKO_HEAD_REF"
                 && cd ./workspace/gecko/taskcluster/scripts/builder
                 && ./build-haz-linux.sh --project browser $HOME/workspace
 
     linux64-mulet-haz/debug:
         description: "Mulet Hazard Analysis Linux"
         index:
@@ -82,12 +80,11 @@ jobs:
             - try
         worker-type: aws-provisioner-v1/mulet-debug  # TODO (taskdiff): change to default
         worker:
             docker-image: {in-tree: builder}
         run:
             using: hazard
             tooltool-manifest: "gecko/b2g/dev/config/tooltool-manifests/linux64/hazard.manifest"
             mozconfig: "b2g/dev/config/mozconfigs/linux64/mulet-hazards"
-            secrets: false  # TODO(taskdiff): don't use secrets for these jobs
             command: >
                 checkout-gecko workspace && cd ./workspace/gecko/taskcluster/scripts/builder
                 && buildbot_step 'Build' ./build-mulet-haz-linux.sh $HOME/workspace