Bug 1301068: Ensure InputExhausted is called if H264Converter drops a frame. r?gerald draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 08 Sep 2016 00:22:06 +1000
changeset 411046 0502ec440382fc3e450ec888d64f82046cf1d996
parent 411045 aad0d3f01642f61f0649396849b23493cf737c8b
child 530662 3d4a549ce8d3fc5e99cb1d75760658265474a0f0
push id28826
push userbmo:jyavenard@mozilla.com
push dateWed, 07 Sep 2016 14:22:54 +0000
reviewersgerald
bugs1301068
milestone51.0a1
Bug 1301068: Ensure InputExhausted is called if H264Converter drops a frame. r?gerald MozReview-Commit-ID: LyZlzU4D58o
dom/media/platforms/wrappers/H264Converter.cpp
--- a/dom/media/platforms/wrappers/H264Converter.cpp
+++ b/dom/media/platforms/wrappers/H264Converter.cpp
@@ -75,16 +75,17 @@ H264Converter::Input(MediaRawData* aSamp
   if (!mDecoder) {
     // It is not possible to create an AVCC H264 decoder without SPS.
     // As such, creation will fail if the extra_data just extracted doesn't
     // contain a SPS.
     rv = CreateDecoderAndInit(aSample);
     if (rv == NS_ERROR_NOT_INITIALIZED) {
       // We are missing the required SPS to create the decoder.
       // Ignore for the time being, the MediaRawData will be dropped.
+      mCallback->InputExhausted();
       return NS_OK;
     }
   } else {
     rv = CheckForSPSChange(aSample);
   }
   NS_ENSURE_SUCCESS(rv, rv);
 
   if (mNeedKeyframe && !aSample->mKeyframe) {