Bug 1293710 - Group activity stream highlights by URL to avoid duplicates. r?ahunt draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Fri, 02 Sep 2016 19:52:56 +0200
changeset 409817 d150ae9341171be9b39a67e314e794f368bcb132
parent 409816 0569fda314ae6ff620279d253ae0ca1e9cfdecee
child 409818 c459babfb73fcfd0436034a5afcced7cea0b140e
push id28557
push users.kaspari@gmail.com
push dateMon, 05 Sep 2016 07:55:10 +0000
reviewersahunt
bugs1293710
milestone51.0a1
Bug 1293710 - Group activity stream highlights by URL to avoid duplicates. r?ahunt The same URL could be picked as highlight from history and from bookmarks. MozReview-Commit-ID: 5vBHluZKfAN
mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java
--- a/mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java
+++ b/mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java
@@ -1193,17 +1193,20 @@ public class BrowserProvider extends Sha
                 "AND " + History.TITLE + " NOT NULL AND " + History.TITLE + " != '' " +
                 "AND " + History.IS_DELETED + " = 0 " +
                 // TODO: Implement block list (bug 1298783)
                 // TODO: Implement domain black list (bug 1298786)
                 // TODO: Group by host (bug 1298785)
                 "ORDER BY " + History.DATE_LAST_VISITED + " DESC " +
                 "LIMIT " + historyLimit + ")";
 
-        final String query = "SELECT DISTINCT * FROM (" + bookmarksQuery + " UNION ALL " + historyQuery + ");";
+        final String query = "SELECT DISTINCT * " +
+                "FROM (" + bookmarksQuery + " " +
+                "UNION ALL " + historyQuery + ") " +
+                "GROUP BY " + Combined.URL + ";";
 
         return db.rawQuery(query, null);
     }
 
     @Override
     public Cursor query(Uri uri, String[] projection, String selection,
             String[] selectionArgs, String sortOrder) {
         final int match = URI_MATCHER.match(uri);