Bug 1297265: P6. Rework Opus Decoder use of InputExhausted. r?kamidphish draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 01 Sep 2016 19:40:15 +1000
changeset 408639 29ecc2232dd5fc1c24aae31b275c2d044b31111c
parent 408638 b92ccba841487ea869a3a5cd22b5c63ff57aeb06
child 408640 180b6420203667d11cf0994026dae12030936677
push id28262
push userbmo:jyavenard@mozilla.com
push dateThu, 01 Sep 2016 12:26:45 +0000
reviewerskamidphish
bugs1297265
milestone51.0a1
Bug 1297265: P6. Rework Opus Decoder use of InputExhausted. r?kamidphish MozReview-Commit-ID: 4Usxx2BrQJt
dom/media/platforms/agnostic/OpusDecoder.cpp
--- a/dom/media/platforms/agnostic/OpusDecoder.cpp
+++ b/dom/media/platforms/agnostic/OpusDecoder.cpp
@@ -158,22 +158,19 @@ OpusDataDecoder::ProcessDecode(MediaRawD
   switch (err) {
     case DecodeError::FATAL_ERROR:
       mCallback->Error(MediaDataDecoderError::FATAL_ERROR);
       return;
     case DecodeError::DECODE_ERROR:
       mCallback->Error(MediaDataDecoderError::DECODE_ERROR);
       break;
     case DecodeError::DECODE_SUCCESS:
+      mCallback->InputExhausted();
       break;
   }
-
-  if (mTaskQueue->IsEmpty()) {
-    mCallback->InputExhausted();
-  }
 }
 
 OpusDataDecoder::DecodeError
 OpusDataDecoder::DoDecode(MediaRawData* aSample)
 {
   int64_t aDiscardPadding = 0;
   if (aSample->mExtraData) {
     aDiscardPadding = BigEndian::readInt64(aSample->mExtraData->Elements());