Bug 1298208 - FX_MIGRATION_HOMEPAGE_IMPORTED probe is (incorrectly) always true. r?mattn
MozReview-Commit-ID: 6wZUeRTKExw
--- a/browser/components/migration/content/migration.js
+++ b/browser/components/migration/content/migration.js
@@ -423,18 +423,19 @@ var MigrationWizard = {
if (label)
label.removeAttribute("style");
break;
case "Migration:Ended":
if (this.isInitialMigration) {
this.reportDataRecencyTelemetry();
}
if (this._autoMigrate) {
- Services.telemetry.getKeyedHistogramById("FX_MIGRATION_HOMEPAGE_IMPORTED")
- .add(this._source, !!this._newHomePage);
+ let hasImportedHomepage = this._newHomePage && this._newHomePage != "DEFAULT";
+ Services.telemetry.getKeyedHistogramById("FX_MIGRATION_IMPORTED_HOMEPAGE")
+ .add(this._source, hasImportedHomepage);
if (this._newHomePage) {
try {
// set homepage properly
var prefSvc = Components.classes["@mozilla.org/preferences-service;1"]
.getService(Components.interfaces.nsIPrefService);
var prefBranch = prefSvc.getBranch(null);
if (this._newHomePage == "DEFAULT") {
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -4576,17 +4576,17 @@
"FX_MIGRATION_USAGE": {
"expires_in_version": "53",
"kind": "enumerated",
"keyed": true,
"n_values": 12,
"releaseChannelCollection": "opt-out",
"description": "Usage of migration for each datatype when migration is run through the post-firstrun flow which allows individual datatypes, keyed by the string description of the browser."
},
- "FX_MIGRATION_HOMEPAGE_IMPORTED": {
+ "FX_MIGRATION_IMPORTED_HOMEPAGE": {
"expires_in_version": "53",
"kind": "boolean",
"keyed": true,
"releaseChannelCollection": "opt-out",
"description": "Whether the homepage was imported during browser migration. Only available on release builds during firstrun."
},
"FX_MIGRATION_BOOKMARKS_IMPORT_MS": {
"bug_numbers": [1289436],