Bug 1298208 - FX_MIGRATION_HOMEPAGE_IMPORTED probe is (incorrectly) always true. r?mattn draft
authorJustin Dolske <dolske@mozilla.com>
Thu, 25 Aug 2016 15:50:41 -0700
changeset 405697 22911b163675f7d4525675a31ad451e9b2304870
parent 405457 7963ebdd52b93f96b812eff2eab8d94097147b9c
child 529508 2e608b4fc6108748ab687e1a8333a1382570583e
push id27559
push userjdolske@mozilla.com
push dateThu, 25 Aug 2016 22:50:54 +0000
reviewersmattn
bugs1298208
milestone51.0a1
Bug 1298208 - FX_MIGRATION_HOMEPAGE_IMPORTED probe is (incorrectly) always true. r?mattn MozReview-Commit-ID: 6wZUeRTKExw
browser/components/migration/content/migration.js
toolkit/components/telemetry/Histograms.json
--- a/browser/components/migration/content/migration.js
+++ b/browser/components/migration/content/migration.js
@@ -423,18 +423,19 @@ var MigrationWizard = {
       if (label)
         label.removeAttribute("style");
       break;
     case "Migration:Ended":
       if (this.isInitialMigration) {
         this.reportDataRecencyTelemetry();
       }
       if (this._autoMigrate) {
-        Services.telemetry.getKeyedHistogramById("FX_MIGRATION_HOMEPAGE_IMPORTED")
-                          .add(this._source, !!this._newHomePage);
+        let hasImportedHomepage = this._newHomePage && this._newHomePage != "DEFAULT";
+        Services.telemetry.getKeyedHistogramById("FX_MIGRATION_IMPORTED_HOMEPAGE")
+                          .add(this._source, hasImportedHomepage);
         if (this._newHomePage) {
           try {
             // set homepage properly
             var prefSvc = Components.classes["@mozilla.org/preferences-service;1"]
                                     .getService(Components.interfaces.nsIPrefService);
             var prefBranch = prefSvc.getBranch(null);
 
             if (this._newHomePage == "DEFAULT") {
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -4576,17 +4576,17 @@
   "FX_MIGRATION_USAGE": {
     "expires_in_version": "53",
     "kind": "enumerated",
     "keyed": true,
     "n_values": 12,
     "releaseChannelCollection": "opt-out",
     "description": "Usage of migration for each datatype when migration is run through the post-firstrun flow which allows individual datatypes, keyed by the string description of the browser."
   },
-  "FX_MIGRATION_HOMEPAGE_IMPORTED": {
+  "FX_MIGRATION_IMPORTED_HOMEPAGE": {
     "expires_in_version": "53",
     "kind": "boolean",
     "keyed": true,
     "releaseChannelCollection": "opt-out",
     "description": "Whether the homepage was imported during browser migration. Only available on release builds during firstrun."
   },
   "FX_MIGRATION_BOOKMARKS_IMPORT_MS": {
     "bug_numbers": [1289436],