Bug 1296618 - Part 4: Remove destructuring of [value, errors] arrays. r?gandalf draft
authorStaś Małolepszy <stas@mozilla.com>
Thu, 25 Aug 2016 17:43:52 +0200
changeset 405647 aa811f01bc390f7f23f6bd7e116e4c53a8df71ec
parent 405646 73eec1e64bc48d1685969888f13a06529fa0506f
child 529501 20a6b9b671491d2cab2d245a3248a7af242dcbed
push id27552
push usersmalolepszy@mozilla.com
push dateThu, 25 Aug 2016 21:48:38 +0000
reviewersgandalf
bugs1296618
milestone51.0a1
Bug 1296618 - Part 4: Remove destructuring of [value, errors] arrays. r?gandalf MozReview-Commit-ID: KOD9FeDJQL0
toolkit/content/l20n-chrome-xul.js
--- a/toolkit/content/l20n-chrome-xul.js
+++ b/toolkit/content/l20n-chrome-xul.js
@@ -318,29 +318,30 @@ function entityFromContext(ctx, id, args
 
   if (entity === undefined) {
     return [
       { value: id, attrs: null },
       [new L10nError(`Unknown entity: ${id}`)]
     ];
   }
 
-  const [value, errors] = ctx.formatToPrimitive(entity, args);
+  const formattedValue = ctx.formatToPrimitive(entity, args);
+  const errors = formattedValue[1];
 
   const formatted = {
-    value,
+    value: formattedValue[0],
     attrs: null,
   };
 
   if (entity.traits) {
     formatted.attrs = Object.create(null);
     for (let trait of entity.traits) {
-      const [attrValue, attrErrors] = ctx.format(trait.val, args);
-      errors.push(...attrErrors);
-      formatted.attrs[trait.key.name] = attrValue;
+      const formattedTrait = ctx.format(trait.val, args);
+      errors.push(...formattedTrait[1]);
+      formatted.attrs[trait.key.name] = formattedTrait[0];
     }
   }
 
   return [formatted, errors];
 }
 
 const properties = new WeakMap();
 const contexts = new WeakMap();
@@ -364,17 +365,19 @@ class Localization {
 
   formatWithFallback(bundles, keys, method, prev) {
     const ctx = contexts.get(bundles[0]);
 
     if (!ctx) {
       return prev.map(tuple => tuple[0]);
     }
 
-    const [translations, errors] = keysFromContext(ctx, keys, method, prev);
+    const formattedTuples = keysFromContext(ctx, keys, method, prev);
+    const translations = formattedTuples[0];
+    const errors = formattedTuples[1];
 
     if (errors.length === 0) {
       return translations.map(tuple => tuple[0]);
     }
 
     if (typeof console !== 'undefined') {
       errors.forEach(e => console.warn(e)); // eslint-disable-line no-console
     }