Bug 1282978 - Accept and ignore the minimum_chrome_version manifest property. r?kmag draft
authorShubheksha Jalan <jshubheksha@gmail.com>
Tue, 30 Aug 2016 00:40:33 +0530
changeset 406871 d08b0913b30835f3477f8c1f50dad789ac05126f
parent 404988 01748a2b1a463f24efd9cd8abad9ccfd76b037b8
child 407980 0b4ee2ba06dd4963d772e215693e9bb4dd57716f
push id27855
push userbmo:jshubheksha@gmail.com
push dateMon, 29 Aug 2016 19:40:01 +0000
reviewerskmag
bugs1282978
milestone51.0a1
Bug 1282978 - Accept and ignore the minimum_chrome_version manifest property. r?kmag MozReview-Commit-ID: C9AlxpQDCnC *** Bug 1282978 - Fixed tabs and spacing issues MozReview-Commit-ID: 3SSpQpvZY2B
toolkit/components/extensions/schemas/manifest.json
toolkit/components/extensions/test/xpcshell/test_ext_manifest_minimum_chrome_version.js
toolkit/components/extensions/test/xpcshell/xpcshell.ini
--- a/toolkit/components/extensions/schemas/manifest.json
+++ b/toolkit/components/extensions/schemas/manifest.json
@@ -8,16 +8,21 @@
         "description": "Represents a WebExtension manifest.json file",
         "properties": {
           "manifest_version": {
             "type": "integer",
             "minimum": 2,
             "maximum": 2
           },
 
+          "minimum_chrome_version":{
+            "type": "string",
+            "optional": true
+          },
+
           "applications": {
             "type": "object",
             "optional": true,
             "properties": {
               "gecko": {
                 "$ref": "FirefoxSpecificProperties",
                 "optional": true
               }
new file mode 100644
--- /dev/null
+++ b/toolkit/components/extensions/test/xpcshell/test_ext_manifest_minimum_chrome_version.js
@@ -0,0 +1,13 @@
+/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
+/* vim: set sts=2 sw=2 et tw=80: */
+"use strict";
+
+
+add_task(function* test_manifest_minimum_chrome_version() {
+  let normalized = yield ExtensionTestUtils.normalizeManifest({
+    "minimum_chrome_version": "42",
+  });
+
+  equal(normalized.error, undefined, "Should not have an error");
+  equal(normalized.errors.length, 0, "Should not have warnings");
+});
--- a/toolkit/components/extensions/test/xpcshell/xpcshell.ini
+++ b/toolkit/components/extensions/test/xpcshell/xpcshell.ini
@@ -31,16 +31,17 @@ skip-if = os == "android"
 skip-if = release_build
 [test_ext_extension.js]
 [test_ext_idle.js]
 [test_ext_json_parser.js]
 [test_ext_localStorage.js]
 [test_ext_management.js]
 [test_ext_manifest_content_security_policy.js]
 [test_ext_manifest_incognito.js]
+[test_ext_manifest_minimum_chrome_version.js]
 [test_ext_onmessage_removelistener.js]
 [test_ext_runtime_connect_no_receiver.js]
 [test_ext_runtime_getPlatformInfo.js]
 [test_ext_runtime_sendMessage.js]
 [test_ext_runtime_sendMessage_errors.js]
 [test_ext_runtime_sendMessage_no_receiver.js]
 [test_ext_schemas.js]
 [test_ext_schemas_api_injection.js]