Bug 1284874 - Update skip decorators and remove dead code in TestScreenOrientation; r?AutomatedTester draft
authorMaja Frydrychowicz <mjzffr@gmail.com>
Mon, 22 Aug 2016 12:28:58 -0400
changeset 405504 2d1595875b134e207801fc628e6ffd0748e529ee
parent 405503 8682ada4759d3b21e18b3d51946eda25e52b52a1
child 405505 81441b18f172945082127e8311027eb53bf02933
push id27507
push usermjzffr@gmail.com
push dateThu, 25 Aug 2016 15:12:45 +0000
reviewersAutomatedTester
bugs1284874, 1274408
milestone51.0a1
Bug 1284874 - Update skip decorators and remove dead code in TestScreenOrientation; r?AutomatedTester Remove if-blocks that depend on code removed in Bug 1274408 MozReview-Commit-ID: JJHEiMBIm1b
testing/marionette/harness/marionette/tests/unit/test_screen_orientation.py
--- a/testing/marionette/harness/marionette/tests/unit/test_screen_orientation.py
+++ b/testing/marionette/harness/marionette/tests/unit/test_screen_orientation.py
@@ -1,14 +1,14 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 from marionette_driver import errors
-from marionette import MarionetteTestCase, skip_if_desktop
+from marionette import MarionetteTestCase, skip_if_desktop, skip_if_mobile
 from mozrunner.devices.emulator_screen import EmulatorScreen
 
 default_orientation = "portrait-primary"
 unknown_orientation = "Unknown screen orientation: %s"
 
 class TestScreenOrientation(MarionetteTestCase):
     def setUp(self):
         MarionetteTestCase.setUp(self)
@@ -21,86 +21,63 @@ class TestScreenOrientation(MarionetteTe
         MarionetteTestCase.tearDown(self)
 
     @skip_if_desktop
     def test_set_orientation_to_portrait_primary(self):
         self.marionette.set_orientation("portrait-primary")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "portrait-primary")
 
-        if self.marionette.emulator:
-            emulator_orientation = self.marionette.emulator.screen.orientation
-            self.assertEqual(emulator_orientation, EmulatorScreen.SO_PORTRAIT_PRIMARY)
-
     @skip_if_desktop
     def test_set_orientation_to_landscape_primary(self):
         self.marionette.set_orientation("landscape-primary")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "landscape-primary")
 
-        if self.marionette.emulator:
-            emulator_orientation = self.marionette.emulator.screen.orientation
-            self.assertEqual(emulator_orientation, EmulatorScreen.SO_LANDSCAPE_PRIMARY)
-
     @skip_if_desktop
     def test_set_orientation_to_portrait_secondary(self):
         self.marionette.set_orientation("portrait-secondary")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "portrait-secondary")
 
-        if self.marionette.emulator:
-            emulator_orientation = self.marionette.emulator.screen.orientation
-            self.assertEqual(emulator_orientation, EmulatorScreen.SO_PORTRAIT_SECONDARY)
-
     @skip_if_desktop
     def test_set_orientation_to_landscape_secondary(self):
         self.marionette.set_orientation("landscape-secondary")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "landscape-secondary")
 
-        if self.marionette.emulator:
-            emulator_orientation = self.marionette.emulator.screen.orientation
-            self.assertEqual(emulator_orientation, EmulatorScreen.SO_LANDSCAPE_SECONDARY)
-
     @skip_if_desktop
     def test_set_orientation_to_shorthand_portrait(self):
         # Set orientation to something other than portrait-primary first, since the default is
         # portrait-primary.
         self.marionette.set_orientation("landscape-primary")
         self.assertEqual(self.marionette.orientation, "landscape-primary", "invalid state")
 
         self.marionette.set_orientation("portrait")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "portrait-primary")
 
-        if self.marionette.emulator:
-            emulator_orientation = self.marionette.emulator.screen.orientation
-            self.assertEqual(emulator_orientation, EmulatorScreen.SO_PORTRAIT_PRIMARY)
-
     @skip_if_desktop
     def test_set_orientation_to_shorthand_landscape(self):
         self.marionette.set_orientation("landscape")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "landscape-primary")
 
-        if self.marionette.emulator:
-            emulator_orientation = self.marionette.emulator.screen.orientation
-            self.assertEqual(emulator_orientation, EmulatorScreen.SO_LANDSCAPE_PRIMARY)
-
     @skip_if_desktop
     def test_set_orientation_with_mixed_casing(self):
         self.marionette.set_orientation("lAnDsCaPe")
         new_orientation = self.marionette.orientation
         self.assertEqual(new_orientation, "landscape-primary")
 
     @skip_if_desktop
     def test_set_invalid_orientation(self):
         with self.assertRaisesRegexp(errors.MarionetteException, unknown_orientation % "cheese"):
             self.marionette.set_orientation("cheese")
 
     @skip_if_desktop
     def test_set_null_orientation(self):
         with self.assertRaisesRegexp(errors.MarionetteException, unknown_orientation % "null"):
             self.marionette.set_orientation(None)
 
+    @skip_if_mobile
     def test_unsupported_operation_on_desktop(self):
         with self.assertRaises(errors.UnsupportedOperationException):
             self.marionette.set_orientation("landscape-primary")