Bug 1296297 - prevent integer overflow in QuotaManager::EnsureOriginIsInitialized. r?jst draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Thu, 18 Aug 2016 17:16:24 +0300
changeset 402561 28097a7ad296b50c5c26636b3c6214fcf4d5a016
parent 400825 054d4856cea6150a6638e5daf7913713281af97d
child 528718 55717de77790f6de380cee5bf0db4b8cee9bb922
push id26708
push userbmo:bpostelnicu@mozilla.com
push dateThu, 18 Aug 2016 14:17:12 +0000
reviewersjst
bugs1296297
milestone51.0a1
Bug 1296297 - prevent integer overflow in QuotaManager::EnsureOriginIsInitialized. r?jst MozReview-Commit-ID: KPYheDCdLa1
dom/quota/ActorsParent.cpp
--- a/dom/quota/ActorsParent.cpp
+++ b/dom/quota/ActorsParent.cpp
@@ -4432,17 +4432,17 @@ QuotaManager::EnsureOriginIsInitialized(
     if (NS_WARN_IF(NS_FAILED(rv))) {
       // We have to cleanup partially initialized quota.
       RemoveQuota();
 
       return rv;
     }
 
     if (gFixedLimitKB >= 0) {
-      mTemporaryStorageLimit = gFixedLimitKB * 1024;
+      mTemporaryStorageLimit = static_cast<uint64_t>(gFixedLimitKB) * 1024;
     }
     else {
       nsCOMPtr<nsIFile> storageDir =
         do_CreateInstance(NS_LOCAL_FILE_CONTRACTID, &rv);
       if (NS_WARN_IF(NS_FAILED(rv))) {
         return rv;
       }