Bug 1049975 - Part 8: Use AnimationEffectReadOnly as the argument type of Animation constructor. draft
authorBoris Chiou <boris.chiou@gmail.com>
Tue, 16 Aug 2016 16:48:55 +0800
changeset 405236 5af756497d1316a293ade37a36e9d1b5c39d0680
parent 405235 95b07957a6479b0ccc33d1fc47a6de8bfd1191ab
child 405237 eba2506e124b88c35fd327f8f5b5d58bc0d247cf
push id27442
push userbmo:boris.chiou@gmail.com
push dateThu, 25 Aug 2016 04:26:27 +0000
bugs1049975
milestone51.0a1
Bug 1049975 - Part 8: Use AnimationEffectReadOnly as the argument type of Animation constructor. MozReview-Commit-ID: 2qoZQuQAweF
dom/animation/Animation.cpp
dom/animation/Animation.h
dom/webidl/Animation.webidl
--- a/dom/animation/Animation.cpp
+++ b/dom/animation/Animation.cpp
@@ -82,17 +82,17 @@ namespace {
 
 // ---------------------------------------------------------------------------
 //
 // Animation interface:
 //
 // ---------------------------------------------------------------------------
 /* static */ already_AddRefed<Animation>
 Animation::Constructor(const GlobalObject& aGlobal,
-                       KeyframeEffectReadOnly* aEffect,
+                       AnimationEffectReadOnly* aEffect,
                        const Optional<AnimationTimeline*>& aTimeline,
                        ErrorResult& aRv)
 {
   nsCOMPtr<nsIGlobalObject> global = do_QueryInterface(aGlobal.GetAsSupports());
   RefPtr<Animation> animation = new Animation(global);
 
   AnimationTimeline* timeline;
   if (aTimeline.WasPassed()) {
--- a/dom/animation/Animation.h
+++ b/dom/animation/Animation.h
@@ -87,17 +87,17 @@ public:
   enum class LimitBehavior {
     AutoRewind,
     Continue
   };
 
   // Animation interface methods
   static already_AddRefed<Animation>
   Constructor(const GlobalObject& aGlobal,
-              KeyframeEffectReadOnly* aEffect,
+              AnimationEffectReadOnly* aEffect,
               const Optional<AnimationTimeline*>& aTimeline,
               ErrorResult& aRv);
   void GetId(nsAString& aResult) const { aResult = mId; }
   void SetId(const nsAString& aId);
   AnimationEffectReadOnly* GetEffect() const { return mEffect; }
   void SetEffect(AnimationEffectReadOnly* aEffect);
   AnimationTimeline* GetTimeline() const { return mTimeline; }
   void SetTimeline(AnimationTimeline* aTimeline);
--- a/dom/webidl/Animation.webidl
+++ b/dom/webidl/Animation.webidl
@@ -8,17 +8,17 @@
  *
  * Copyright © 2015 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
  */
 
 enum AnimationPlayState { "idle", "pending", "running", "paused", "finished" };
 
 [Func="nsDocument::IsElementAnimateEnabled",
- Constructor (optional KeyframeEffectReadOnly? effect = null,
+ Constructor (optional AnimationEffectReadOnly? effect = null,
               optional AnimationTimeline? timeline)]
 interface Animation : EventTarget {
   attribute DOMString id;
   [Func="nsDocument::IsWebAnimationsEnabled", Pure]
   attribute AnimationEffectReadOnly? effect;
   [Func="nsDocument::IsWebAnimationsEnabled"]
   attribute AnimationTimeline? timeline;
   [BinaryName="startTimeAsDouble"]