Bug 1294366 - css filter tootlip: shorten empty presets helptext;r=ochameau draft
authorJulian Descottes <jdescottes@mozilla.com>
Tue, 16 Aug 2016 22:16:33 +0200
changeset 401280 d74025a3fa9bbdc0299dcd9a5513ce81a6bc2b3b
parent 401279 fb5a5b80cd787049945ff30db54ad4efcc4e179f
child 528451 5b1a278f45e1aff050f79f15139c7e3de47e230e
push id26419
push userjdescottes@mozilla.com
push dateTue, 16 Aug 2016 20:19:00 +0000
reviewersochameau
bugs1294366
milestone51.0a1
Bug 1294366 - css filter tootlip: shorten empty presets helptext;r=ochameau Use a shorter text that will have more chance to fit in the tooltip even if the height is reduced. Using a separate commit here so that we can easily uplift the first part to aurora without having to embed a string change. MozReview-Commit-ID: BCDUAWsB0q1
devtools/client/locales/en-US/filterwidget.properties
devtools/client/shared/widgets/FilterWidget.js
--- a/devtools/client/locales/en-US/filterwidget.properties
+++ b/devtools/client/locales/en-US/filterwidget.properties
@@ -6,21 +6,20 @@
 # which can be found in a tooltip that appears in the Rule View when clicking
 # on a filter swatch displayed next to CSS declarations like 'filter: blur(2px)'.
 
 # LOCALIZATION NOTE (emptyFilterList):
 # This string is displayed when filter's list is empty
 # (no filter specified / all removed)
 emptyFilterList=No filter specified
 
-# LOCALIZATION NOTE (emptyPresetList):
+# LOCALIZATION NOTE (emptyPresetListShort):
 # This string is displayed when preset's list is empty
-emptyPresetList=You don’t have any saved presets. \
-You can store filter presets by choosing a name and saving them. \
-Presets are quickly accessible and you can re-use them with ease.
+emptyPresetListShort=You don’t have any saved presets. \
+You can store filter presets by choosing a name and saving them.
 
 # LOCALIZATION NOTE (addUsingList):
 # This string is displayed under [emptyFilterList] when filter's
 # list is empty, guiding user to add a filter using the list below it
 addUsingList=Add a filter using the list below
 
 # LOCALIZATION NOTE (dropShadowPlaceholder):
 # This string is used as a placeholder for drop-shadow's input
--- a/devtools/client/shared/widgets/FilterWidget.js
+++ b/devtools/client/shared/widgets/FilterWidget.js
@@ -689,17 +689,17 @@ CSSFilterEditorWidget.prototype = {
   renderPresets: function () {
     this.getPresets().then(presets => {
       // getPresets is async and the widget may be destroyed in between.
       if (!this.presetsList) {
         return;
       }
 
       if (!presets || !presets.length) {
-        this.presetsList.innerHTML = `<p>${L10N.getStr("emptyPresetList")}</p>`;
+        this.presetsList.innerHTML = `<p>${L10N.getStr("emptyPresetListShort")}</p>`;
         this.emit("render");
         return;
       }
       let base = this._presetItemMarkup;
 
       this.presetsList.innerHTML = "";
 
       for (let [index, preset] of presets.entries()) {