Bug 1295492 - Add support for --binary argument to Marionette mach command. r?maja_zf draft
authorHenrik Skupin <mail@hskupin.info>
Tue, 30 Aug 2016 10:53:07 +0200
changeset 407340 2745c17a5fe670c3b9125296f2d959a25af1a1a8
parent 406838 acfb2c3ac6ae0a704e2756184815296ac1314f89
child 529849 7a52f198c856e363d0fb82dd42a7738035fea4eb
push id27935
push userbmo:hskupin@gmail.com
push dateTue, 30 Aug 2016 08:57:29 +0000
reviewersmaja_zf
bugs1295492
milestone51.0a1
Bug 1295492 - Add support for --binary argument to Marionette mach command. r?maja_zf MozReview-Commit-ID: 6tru2Ms135j
testing/marionette/mach_commands.py
--- a/testing/marionette/mach_commands.py
+++ b/testing/marionette/mach_commands.py
@@ -146,29 +146,27 @@ class MachCommands(MachCommandBase):
     )
     def run_marionette_test(self, tests, **kwargs):
         if 'test_objects' in kwargs:
             tests = []
             for obj in kwargs['test_objects']:
                 tests.append(obj['file_relpath'])
             del kwargs['test_objects']
 
-        if conditions.is_firefox(self):
-            bin_path = self.get_binary_path('app')
-            if kwargs.get('binary') is not None:
-                print "Warning: ignoring '--binary' option, using binary at " + bin_path
-            kwargs['binary'] = bin_path
+        if not kwargs.get('binary') and conditions.is_firefox(self):
+            kwargs['binary'] = self.get_binary_path('app')
         return run_marionette(tests, topsrcdir=self.topsrcdir, **kwargs)
 
     @Command('session-test', category='testing',
         description='Run a Session test (Check Telemetry using marionette).',
         conditions=[conditions.is_firefox],
         parser=setup_session_argument_parser,
     )
     def run_session_test(self, tests, **kwargs):
         if 'test_objects' in kwargs:
             tests = []
             for obj in kwargs['test_objects']:
                 tests.append(obj['file_relpath'])
             del kwargs['test_objects']
 
-        kwargs['binary'] = self.get_binary_path('app')
-        return run_session(tests, topsrcdir=self.topsrcdir, **kwargs)
\ No newline at end of file
+        if not kwargs.get('binary') and conditions.is_firefox(self):
+            kwargs['binary'] = self.get_binary_path('app')
+        return run_session(tests, topsrcdir=self.topsrcdir, **kwargs)