Bug 1295103 - Check OriginAttributes::PopulateFromSuffix return value in PackagedAppVerifier. r=honzab draft
authorKan-Ru Chen <kanru@kanru.info>
Mon, 15 Aug 2016 18:19:44 +0800
changeset 404364 573eea59bf2efae6109c74b230dc3dc5b825ed70
parent 404363 790679ea5bef333f98783c7d3aeed1729b1a9b1f
child 404365 d7897a47bb5dc1c588bbbd6c57e8edce158690f2
push id27198
push userbmo:kchen@mozilla.com
push dateTue, 23 Aug 2016 10:29:41 +0000
reviewershonzab
bugs1295103
milestone51.0a1
Bug 1295103 - Check OriginAttributes::PopulateFromSuffix return value in PackagedAppVerifier. r=honzab MozReview-Commit-ID: 7V4vEZKWYHw
netwerk/protocol/http/PackagedAppVerifier.cpp
--- a/netwerk/protocol/http/PackagedAppVerifier.cpp
+++ b/netwerk/protocol/http/PackagedAppVerifier.cpp
@@ -77,17 +77,18 @@ NS_IMETHODIMP PackagedAppVerifier::Init(
   mListener = aListener;
   mState = STATE_UNKNOWN;
   mSignature = aSignature;
   mIsPackageSigned = false;
   mPackageCacheEntry = aPackageCacheEntry;
   mIsFirstResource = true;
   mManifest = EmptyCString();
 
-  NeckoOriginAttributes().PopulateFromOrigin(aPackageOrigin, mPackageOrigin);
+  bool success = NeckoOriginAttributes().PopulateFromOrigin(aPackageOrigin, mPackageOrigin);
+  NS_ENSURE_TRUE(success, NS_ERROR_FAILURE);
   mBypassVerification = (mPackageOrigin ==
       Preferences::GetCString("network.http.signed-packages.trusted-origin"));
 
   LOG(("mBypassVerification = %d\n", mBypassVerification));
   LOG(("mPackageOrigin = %s\n", mPackageOrigin.get()));
 
   nsresult rv;
   mPackagedAppUtils = do_CreateInstance(NS_PACKAGEDAPPUTILS_CONTRACTID, &rv);