Bug 1295103 - Check OriginAttributes::PopulateFromSuffix return value in PackagedAppVerifier. r=honzab
MozReview-Commit-ID: 7V4vEZKWYHw
--- a/netwerk/protocol/http/PackagedAppVerifier.cpp
+++ b/netwerk/protocol/http/PackagedAppVerifier.cpp
@@ -77,17 +77,18 @@ NS_IMETHODIMP PackagedAppVerifier::Init(
mListener = aListener;
mState = STATE_UNKNOWN;
mSignature = aSignature;
mIsPackageSigned = false;
mPackageCacheEntry = aPackageCacheEntry;
mIsFirstResource = true;
mManifest = EmptyCString();
- NeckoOriginAttributes().PopulateFromOrigin(aPackageOrigin, mPackageOrigin);
+ bool success = NeckoOriginAttributes().PopulateFromOrigin(aPackageOrigin, mPackageOrigin);
+ NS_ENSURE_TRUE(success, NS_ERROR_FAILURE);
mBypassVerification = (mPackageOrigin ==
Preferences::GetCString("network.http.signed-packages.trusted-origin"));
LOG(("mBypassVerification = %d\n", mBypassVerification));
LOG(("mPackageOrigin = %s\n", mPackageOrigin.get()));
nsresult rv;
mPackagedAppUtils = do_CreateInstance(NS_PACKAGEDAPPUTILS_CONTRACTID, &rv);