Bug 1153292 - part0: aboutdebugging: titles on target-name components;r=janx draft
authorJulian Descottes <jdescottes@mozilla.com>
Tue, 16 Aug 2016 16:33:34 +0200
changeset 420131 26f30041f37eb870bf2fc94bdcbb58287c326673
parent 420130 47bc79e87ead79129b452f26d65aa6811bb967b7
child 420132 caca55e0004d2479cd2fb5358cf45fa9455493b1
push id31104
push userjdescottes@mozilla.com
push dateMon, 03 Oct 2016 13:33:13 +0000
reviewersjanx
bugs1153292
milestone52.0a1
Bug 1153292 - part0: aboutdebugging: titles on target-name components;r=janx MozReview-Commit-ID: GkBCcjuLU6R
devtools/client/aboutdebugging/components/addons/target.js
devtools/client/aboutdebugging/components/workers/service-worker-target.js
devtools/client/aboutdebugging/components/workers/target.js
--- a/devtools/client/aboutdebugging/components/addons/target.js
+++ b/devtools/client/aboutdebugging/components/addons/target.js
@@ -42,17 +42,17 @@ module.exports = createClass({
 
     return dom.li({ className: "target-container" },
       dom.img({
         className: "target-icon",
         role: "presentation",
         src: target.icon
       }),
       dom.div({ className: "target" },
-        dom.div({ className: "target-name" }, target.name)
+        dom.div({ className: "target-name", title: target.name }, target.name)
       ),
       dom.button({
         className: "debug-button",
         onClick: this.debug,
         disabled: debugDisabled,
       }, Strings.GetStringFromName("debug")),
       dom.button({
         className: "reload-button",
--- a/devtools/client/aboutdebugging/components/workers/service-worker-target.js
+++ b/devtools/client/aboutdebugging/components/workers/service-worker-target.js
@@ -109,28 +109,33 @@ module.exports = createClass({
 
     return dom.div({ className: "target-container" },
       dom.img({
         className: "target-icon",
         role: "presentation",
         src: target.icon
       }),
       dom.div({ className: "target" },
-        dom.div({ className: "target-name" }, target.name),
+        dom.div({ className: "target-name", title: target.name }, target.name),
         dom.ul({ className: "target-details" },
           (pushSubscription ?
             dom.li({ className: "target-detail" },
               dom.strong(null, Strings.GetStringFromName("pushService")),
-              dom.span({ className: "service-worker-push-url" },
-                pushSubscription.endpoint)) :
+              dom.span({
+                className: "service-worker-push-url",
+                title: pushSubscription.endpoint
+              }, pushSubscription.endpoint)) :
             null
           ),
           dom.li({ className: "target-detail" },
             dom.strong(null, Strings.GetStringFromName("scope")),
-            dom.span({ className: "service-worker-scope" }, target.scope),
+            dom.span({
+              className: "service-worker-scope",
+              title: target.scope
+            }, target.scope),
             dom.a({
               onClick: this.unregister,
               className: "unregister-link"
             }, Strings.GetStringFromName("unregister"))
           )
         )
       ),
       (isRunning ?
--- a/devtools/client/aboutdebugging/components/workers/target.js
+++ b/devtools/client/aboutdebugging/components/workers/target.js
@@ -27,17 +27,17 @@ module.exports = createClass({
 
     return dom.li({ className: "target-container" },
       dom.img({
         className: "target-icon",
         role: "presentation",
         src: target.icon
       }),
       dom.div({ className: "target" },
-        dom.div({ className: "target-name" }, target.name)
+        dom.div({ className: "target-name", title: target.name }, target.name)
       ),
       dom.button({
         className: "debug-button",
         onClick: this.debug,
         disabled: debugDisabled
       }, Strings.GetStringFromName("debug"))
     );
   }