Bug 1293836, remove --release-to-latest-tinderbox-builds from post_upload commands, r?rail draft
authorNick Thomas <nthomas@mozilla.com>
Fri, 12 Aug 2016 10:55:13 +1200
changeset 4892 7d9d1fea7e94fe3c9e32c26083470f30e6346a7e
parent 4891 307646eb0970c5b048befeac1c9c46fd1b49e4e6
push id3644
push usernthomas@mozilla.com
push dateThu, 11 Aug 2016 23:04:30 +0000
reviewersrail
bugs1293836
Bug 1293836, remove --release-to-latest-tinderbox-builds from post_upload commands, r?rail This removes the --release-to-latest-tinderbox-builds argument, which is not supported since we moved to S3 in Oct 2015. It also removes the log argument from postUploadCmdPrefix(), which was only set in log_uploader.py to avoid putting logs into latest directories. MozReview-Commit-ID: 7dNxuGcD8ck
bin/log_uploader.py
process/factory.py
--- a/bin/log_uploader.py
+++ b/bin/log_uploader.py
@@ -316,17 +316,16 @@ if __name__ == "__main__":
                     files=[logfile], remote_dir=remote_tmpdir)
 
                 remote_files = [os.path.join(
                     remote_tmpdir, os.path.basename(f)) for f in [logfile]]
 
             uploadArgs = dict(
                 branch=options.branch,
                 product=options.product,
-                log=True,
             )
 
             # Make sure debug platforms are properly identified
             # Test builders don't have the '-debug' distinction in the platform
             # string, so check in the builder name to make sure.
             platform = options.platform
             if platform:
                 if '-debug' in builder_path and '-debug' not in platform:
--- a/process/factory.py
+++ b/process/factory.py
@@ -121,17 +121,16 @@ def postUploadCmdPrefix(upload_dir=None,
                         to_dated=False,
                         to_latest=False,
                         to_try=False,
                         to_candidates=False,
                         to_mobile_candidates=False,
                         nightly_dir=None,
                         as_list=True,
                         signed=False,
-                        log=False,
                         bucket_prefix=None,
                         ):
     """Returns a post_upload.py command line for the given arguments.
 
     If as_list is True (the default), the command line will be returned as a
     list of arguments.  Some arguments may be WithProperties instances.
 
     If as_list is False, the command will be returned as a WithProperties
@@ -158,18 +157,16 @@ def postUploadCmdPrefix(upload_dir=None,
     if revision:
         cmd.extend(['--revision', revision])
     if who:
         cmd.extend(['--who', who])
     if builddir:
         cmd.extend(['--builddir', builddir])
     if to_tinderbox_dated:
         cmd.append('--release-to-tinderbox-dated-builds')
-        if not log:
-            cmd.append('--release-to-latest-tinderbox-builds')
     if to_tinderbox_builds:
         cmd.append('--release-to-tinderbox-builds')
     if to_try:
         cmd.append('--release-to-try-builds')
     if to_latest:
         cmd.append("--release-to-latest")
     if to_dated:
         cmd.append("--release-to-dated")