Bug 1291707 part 2 - Add GetAndRemove to nsDataHashtable. r?froydnj draft
authorXidorn Quan <xidorn+moz@upsuper.org>
Tue, 16 Aug 2016 09:28:33 +1000
changeset 400843 acea60ceaa93726f482779ab1d8578fb4c1d7cb2
parent 400842 dfbff1f4282fc6bacc2e12c6b727afdab70000ba
child 400844 00251e8763546c2cccdf9e637e5c58ea38a26612
push id26297
push userxquan@mozilla.com
push dateMon, 15 Aug 2016 23:30:49 +0000
reviewersfroydnj
bugs1291707
milestone51.0a1
Bug 1291707 part 2 - Add GetAndRemove to nsDataHashtable. r?froydnj MozReview-Commit-ID: 24zlYwsRGsF
xpcom/glue/nsDataHashtable.h
--- a/xpcom/glue/nsDataHashtable.h
+++ b/xpcom/glue/nsDataHashtable.h
@@ -4,30 +4,55 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef nsDataHashtable_h__
 #define nsDataHashtable_h__
 
 #include "nsHashKeys.h"
 #include "nsBaseHashtable.h"
+#include "mozilla/Maybe.h"
 
 /**
  * templated hashtable class maps keys to simple datatypes.
  * See nsBaseHashtable for complete declaration
  * @param KeyClass a wrapper-class for the hashtable key, see nsHashKeys.h
  *   for a complete specification.
  * @param DataType the simple datatype being wrapped
  * @see nsInterfaceHashtable, nsClassHashtable
  */
 template<class KeyClass, class DataType>
 class nsDataHashtable
   : public nsBaseHashtable<KeyClass, DataType, DataType>
 {
+private:
+  typedef nsBaseHashtable<KeyClass, DataType, DataType> BaseClass;
+
 public:
+  using typename BaseClass::KeyType;
+  using typename BaseClass::EntryType;
+
   nsDataHashtable() {}
   explicit nsDataHashtable(uint32_t aInitLength)
-    : nsBaseHashtable<KeyClass, DataType, DataType>(aInitLength)
+    : BaseClass(aInitLength)
   {
   }
+
+  /**
+   * Retrieve the value for a key and remove the corresponding entry at
+   * the same time.
+   *
+   * @param aKey the key to retrieve and remove
+   * @return the found value, or Nothing if no entry was found with the
+   *   given key.
+   */
+  mozilla::Maybe<DataType> GetAndRemove(KeyType aKey)
+  {
+    mozilla::Maybe<DataType> value;
+    if (EntryType* ent = this->GetEntry(aKey)) {
+      value.emplace(mozilla::Move(ent->mData));
+      this->RemoveEntry(ent);
+    }
+    return value;
+  }
 };
 
 #endif // nsDataHashtable_h__