Bug 1293737 - Add some common settings to global hgrc; r?dustin draft
authorGregory Szorc <gps@mozilla.com>
Tue, 09 Aug 2016 11:40:57 -0700
changeset 398797 d0c8d84686d0114e9fb3f2133433146e4e107c74
parent 398795 da77c928ed1f2411625a354f328adad257d6d837
child 398890 10c23e45656a6823dfcc36359dd15d77a6efbb22
push id25630
push userbmo:gps@mozilla.com
push dateTue, 09 Aug 2016 18:49:47 +0000
reviewersdustin
bugs1293737, 1250904
milestone51.0a1
Bug 1293737 - Add some common settings to global hgrc; r?dustin The install-mercurial.sh script takes care of installing a global hgrc. If we want Mercurial settings, that's where they should be defined. A number of Docker images had redundantly maintained versions of /home/worker/.hgrc. We've deleted some instances of these hgrc files because I thought they were cargo culted. It turns out that the config was added to support one-click loaners (see bug 1250904). Since there is little harm in enabling extensions globally, we just do that in the shared install-mercurial.sh script and do away with the custom hgrc. It's worth noting that the CA path defined in the custom hgrc is not needed because the Mercurial package installed by install-mercurial.sh configures this correctly. MozReview-Commit-ID: bk4ek99X4z
testing/docker/desktop-test/Dockerfile
testing/docker/desktop-test/dot-files/hgrc
testing/docker/recipes/install-mercurial.sh
--- a/testing/docker/desktop-test/Dockerfile
+++ b/testing/docker/desktop-test/Dockerfile
@@ -30,17 +30,16 @@ ENV           USER          worker
 ENV           LOGNAME       worker
 ENV           HOSTNAME      taskcluster-worker
 ENV           LANG          en_US.UTF-8
 ENV           LC_ALL        en_US.UTF-8
 
 # Add utilities and configuration
 COPY           dot-files/config              /home/worker/.config
 COPY           dot-files/pulse               /home/worker/.pulse
-COPY           dot-files/hgrc                /home/worker/.hgrc
 COPY           bin                           /home/worker/bin
 RUN            chmod +x bin/*
 # TODO: remove this when buildbot is gone
 COPY           buildprops.json               /home/worker/buildprops.json
 COPY           tc-vcs-config.yml /etc/taskcluster-vcs.yml
 
 # TODO: remove
 ADD            https://raw.githubusercontent.com/taskcluster/buildbot-step/master/buildbot_step /home/worker/bin/buildbot_step
deleted file mode 100644
--- a/testing/docker/desktop-test/dot-files/hgrc
+++ /dev/null
@@ -1,12 +0,0 @@
-[diff]
-showfunc = 1
-unified = 8
-
-[extensions]
-color =
-pager =
-progress =
-rebase =
-
-[web]
-cacerts = /etc/ssl/certs/ca-certificates.crt
--- a/testing/docker/recipes/install-mercurial.sh
+++ b/testing/docker/recipes/install-mercurial.sh
@@ -81,11 +81,31 @@ delay = 1.0
 refresh = 1.0
 assume-tty = true
 
 [web]
 cacerts = /etc/ssl/certs/ca-certificates.crt
 
 [extensions]
 robustcheckout = /usr/local/mercurial/robustcheckout.py
+
+# Settings to make 1-click loaners more useful.
+[extensions]
+color =
+histedit =
+pager =
+rebase =
+
+[diff]
+git = 1
+showfunc = 1
+
+[pager]
+pager = LESS=FRSXQ less
+
+attend-help = true
+attend-incoming = true
+attend-log = true
+attend-outgoing = true
+attend-status = true
 EOF
 
 chmod 644 /etc/mercurial/hgrc