Bug 1000957: Use argument instead of member variable InitAxesFromModernProps. r?dholbert draft
authorEmilio Cobos Álvarez <ecoal95@gmail.com>
Mon, 08 Aug 2016 15:56:42 -0700
changeset 398819 57077397f1751d36269f27a171649eeeced4a4c0
parent 398818 5c1f003cafb9dead4c706c0242438e1124763c2b
child 527756 f8f4ed9b917c5972915c895a7a4abaef289e1c7f
push id25639
push userbmo:ealvarez@mozilla.com
push dateTue, 09 Aug 2016 19:53:17 +0000
reviewersdholbert
bugs1000957
milestone51.0a1
Bug 1000957: Use argument instead of member variable InitAxesFromModernProps. r?dholbert In practice it does not make a difference, because mWM is just set before the call, but I bet this is the intended thing. We could take rid of the argument entirely though. MozReview-Commit-ID: CWPGLrd1jPb
layout/generic/nsFlexContainerFrame.cpp
--- a/layout/generic/nsFlexContainerFrame.cpp
+++ b/layout/generic/nsFlexContainerFrame.cpp
@@ -3300,19 +3300,19 @@ FlexboxAxisTracker::InitAxesFromModernPr
   const nsStylePosition* stylePos = aFlexContainer->StylePosition();
   uint32_t flexDirection = stylePos->mFlexDirection;
 
   // Inline dimension ("start-to-end"):
   // (NOTE: I'm intentionally not calling these "inlineAxis"/"blockAxis", since
   // those terms have explicit definition in the writing-modes spec, which are
   // the opposite of how I'd be using them here.)
   AxisOrientationType inlineDimension =
-    InlineDirToAxisOrientation(mWM.GetInlineDir());
+    InlineDirToAxisOrientation(aWM.GetInlineDir());
   AxisOrientationType blockDimension =
-    BlockDirToAxisOrientation(mWM.GetBlockDir());
+    BlockDirToAxisOrientation(aWM.GetBlockDir());
 
   // Determine main axis:
   switch (flexDirection) {
     case NS_STYLE_FLEX_DIRECTION_ROW:
       mMainAxis = inlineDimension;
       mIsRowOriented = true;
       mIsMainAxisReversed = false;
       break;