Bug 1293686 - Move ubuntu1604-test's system-setup.sh to recipes; r?dustin draft
authorGregory Szorc <gps@mozilla.com>
Tue, 09 Aug 2016 09:34:03 -0700
changeset 398708 dd2c135c4640da876daffcceb4f78237f96ebe0a
parent 398684 110678b15eff5d4a7c2cba7879bac6229237ba2e
child 398709 49b708b39d6e0de7c8c5f52fc1f3d57b45cc9645
push id25605
push userbmo:gps@mozilla.com
push dateTue, 09 Aug 2016 16:50:07 +0000
reviewersdustin
bugs1293686
milestone51.0a1
Bug 1293686 - Move ubuntu1604-test's system-setup.sh to recipes; r?dustin In preparation for removing the ubuntu1604-test base image. We also change the script's location in the image to /setup because that's the path we use in most images. MozReview-Commit-ID: CvjTO8hmIkW
testing/docker/recipes/ubuntu1604-test-system-setup.sh
testing/docker/ubuntu1604-test/Dockerfile
testing/docker/ubuntu1604-test/system-setup.sh
rename from testing/docker/ubuntu1604-test/system-setup.sh
rename to testing/docker/recipes/ubuntu1604-test-system-setup.sh
--- a/testing/docker/ubuntu1604-test/system-setup.sh
+++ b/testing/docker/recipes/ubuntu1604-test-system-setup.sh
@@ -172,9 +172,9 @@ apt-get -q -y -f install \
 cp sources.list.orig /etc/apt/sources.list
 apt-get update
 
 # clean up
 cd /
 rm -rf /setup ~/.ccache ~/.cache ~/.npm
 apt-get clean
 apt-get autoclean
-rm $0
+rm -f $0
--- a/testing/docker/ubuntu1604-test/Dockerfile
+++ b/testing/docker/ubuntu1604-test/Dockerfile
@@ -5,19 +5,19 @@ RUN useradd -d /home/worker -s /bin/bash
 WORKDIR /home/worker
 
 # %include testing/docker/recipes/tooltool.py
 ADD topsrcdir/testing/docker/recipes/tooltool.py /setup/tooltool.py
 
 # %include testing/docker/recipes/install-mercurial.sh
 ADD topsrcdir/testing/docker/recipes/install-mercurial.sh /setup/install-mercurial.sh
 
-# install non-build specific dependencies in a single layer
-ADD           system-setup.sh   /tmp/system-setup.sh
-RUN           bash /tmp/system-setup.sh
+# %include testing/docker/recipes/ubuntu1604-test-system-setup.sh
+ADD topsrcdir/testing/docker/recipes/ubuntu1604-test-system-setup.sh /setup/system-setup.sh
+RUN           bash /setup/system-setup.sh
 
 # %include testing/docker/recipes/run-task
 ADD topsrcdir/testing/docker/recipes/run-task /home/worker/bin/run-task
 
 # Set variable normally configured at login, by the shells parent process, these
 # are taken from GNU su manual
 ENV           HOME          /home/worker
 ENV           SHELL         /bin/bash