Bug 1255955 - Check for pointer-interactability on click; r?automatedtester draft
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 09 Aug 2016 14:10:57 +0100
changeset 398578 50da9f1be66821db164d13d61eee4b1dec014572
parent 398577 bbe2f196d3f12990333fa2643d95644cb96faa97
child 527701 3993df1f35160acc7cfabe57fe0ae6160504a8b2
push id25574
push userbmo:ato@mozilla.com
push dateTue, 09 Aug 2016 13:26:03 +0000
reviewersautomatedtester
bugs1255955
milestone51.0a1
Bug 1255955 - Check for pointer-interactability on click; r?automatedtester According to the WebDriver specification patch found in https://github.com/w3c/webdriver/pull/321/files#diff-ce5a67d95770dc70b1b4250c7a9348f2R4138 we should only check for pointer-interactability on clicking an element. This makes sense of the `if (!visible)` check. MozReview-Commit-ID: IV0XYvvXR5a
testing/marionette/interaction.js
--- a/testing/marionette/interaction.js
+++ b/testing/marionette/interaction.js
@@ -108,21 +108,21 @@ interaction.clickElement = function(el, 
     let visibilityCheckEl = el;
     if (el.localName == "option") {
       selectEl = interaction.getSelectForOptionElement(el);
       visibilityCheckEl = selectEl;
     }
 
     let visible = false;
     if (specCompat) {
-      visible = element.isInteractable(visibilityCheckEl);
+      visible = element.isPointerInteractable(visibilityCheckEl);
       if (!visible) {
         el.scrollIntoView(false);
       }
-      visible = element.isInteractable(visibilityCheckEl);
+      visible = element.isPointerInteractable(visibilityCheckEl);
     } else {
       visible = element.isVisible(visibilityCheckEl);
     }
 
     if (!visible) {
       throw new ElementNotVisibleError("Element is not visible");
     }
     resolve(visible);