Bug 1256730 - Fail configure when API keyfiles do not exist or are empty. r?chmanchester
--- a/build/moz.configure/keyfiles.configure
+++ b/build/moz.configure/keyfiles.configure
@@ -10,25 +10,27 @@ def keyfile(desc, help=None):
help = help or ('Use the secret key contained in the given keyfile '
'for %s requests' % desc)
name = desc.lower().replace(' ', '-')
option('--with-%s-keyfile' % name, nargs=1, help=help)
@depends('--with-%s-keyfile' % name)
@checking('for the %s key file' % name, lambda x: bool(x))
@imports(_from='__builtin__', _import='open')
+ @imports(_from='__builtin__', _import='Exception')
def keyfile(value):
if value:
try:
with open(value[0]) as fh:
result = fh.read().strip()
if result:
return result
- except:
- pass
+ raise FatalCheckError('%s is empty' % value[0])
+ except Exception as e:
+ raise FatalCheckError(str(e))
return 'no-%s-key' % name
return keyfile
@template
def simple_keyfile(desc):
set_config('MOZ_%s_KEY' % desc.upper().replace(' ', '_'),