Bug 1292463 - Rename compilechecks.configure and test_header_checks.py. r?chmanchester draft
authorMike Hommey <mh+mozilla@glandium.org>
Tue, 09 Aug 2016 08:25:35 +0900
changeset 398348 87ece4a66c2247bfbb8fa94c03b6e83c0c88babe
parent 398345 38915e2c6ca97e0340b2d6ce914b40466f6714b3
child 398349 e91e3e6aefacb0a35a3becef410d9efa2632d28a
push id25499
push userbmo:mh+mozilla@glandium.org
push dateTue, 09 Aug 2016 00:19:16 +0000
reviewerschmanchester
bugs1292463
milestone51.0a1
Bug 1292463 - Rename compilechecks.configure and test_header_checks.py. r?chmanchester to, respectively, compile-checks.configure and test_compile_checks.py.
build/moz.configure/compile-checks.configure
build/moz.configure/compilechecks.configure
build/moz.configure/toolchain.configure
python/moz.build
python/mozbuild/mozbuild/test/configure/test_compile_checks.py
python/mozbuild/mozbuild/test/configure/test_header_checks.py
rename from build/moz.configure/compilechecks.configure
rename to build/moz.configure/compile-checks.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -759,17 +759,17 @@ def compiler(language, host_or_target, c
 
 c_compiler = compiler('C', target)
 cxx_compiler = compiler('C++', target, c_compiler=c_compiler)
 host_c_compiler = compiler('C', host, other_compiler=c_compiler)
 host_cxx_compiler = compiler('C++', host, c_compiler=host_c_compiler,
                              other_compiler=cxx_compiler,
                              other_c_compiler=c_compiler)
 
-include('compilechecks.configure')
+include('compile-checks.configure')
 
 @depends(c_compiler)
 def default_debug_flags(compiler_info):
     # Debug info is ON by default.
     if compiler_info.type == 'msvc':
         return '-Zi'
     return '-g'
 
--- a/python/moz.build
+++ b/python/moz.build
@@ -33,18 +33,18 @@ PYTHON_UNIT_TESTS += [
     'mozbuild/mozbuild/test/action/test_package_fennec_apk.py',
     'mozbuild/mozbuild/test/backend/test_android_eclipse.py',
     'mozbuild/mozbuild/test/backend/test_build.py',
     'mozbuild/mozbuild/test/backend/test_configenvironment.py',
     'mozbuild/mozbuild/test/backend/test_recursivemake.py',
     'mozbuild/mozbuild/test/backend/test_visualstudio.py',
     'mozbuild/mozbuild/test/compilation/test_warnings.py',
     'mozbuild/mozbuild/test/configure/test_checks_configure.py',
+    'mozbuild/mozbuild/test/configure/test_compile_checks.py',
     'mozbuild/mozbuild/test/configure/test_configure.py',
-    'mozbuild/mozbuild/test/configure/test_header_checks.py',
     'mozbuild/mozbuild/test/configure/test_moz_configure.py',
     'mozbuild/mozbuild/test/configure/test_options.py',
     'mozbuild/mozbuild/test/configure/test_toolchain_configure.py',
     'mozbuild/mozbuild/test/configure/test_toolchain_helpers.py',
     'mozbuild/mozbuild/test/configure/test_util.py',
     'mozbuild/mozbuild/test/controller/test_ccachestats.py',
     'mozbuild/mozbuild/test/controller/test_clobber.py',
     'mozbuild/mozbuild/test/frontend/test_context.py',
rename from python/mozbuild/mozbuild/test/configure/test_header_checks.py
rename to python/mozbuild/mozbuild/test/configure/test_compile_checks.py
--- a/python/mozbuild/mozbuild/test/configure/test_header_checks.py
+++ b/python/mozbuild/mozbuild/test/configure/test_compile_checks.py
@@ -77,17 +77,17 @@ class TestHeaderChecks(unittest.TestCase
 
         config = {}
         out = StringIO()
         sandbox = ConfigureTestSandbox(paths, config, {}, ['/bin/configure'],
                                        out, out)
         sandbox.include_file(os.path.join(base_dir, 'util.configure'))
         sandbox.include_file(os.path.join(base_dir, 'checks.configure'))
         exec_(mock_compiler_defs, sandbox)
-        sandbox.include_file(os.path.join(base_dir, 'compilechecks.configure'))
+        sandbox.include_file(os.path.join(base_dir, 'compile-checks.configure'))
 
         status = 0
         try:
             exec_(command, sandbox)
             sandbox.run()
         except SystemExit as e:
             status = e.code