Bug 1000957: Uncomment some flexbox warnings referencing fixed bugs. r?dholbert draft
authorEmilio Cobos Álvarez <ecoal95@gmail.com>
Sun, 07 Aug 2016 19:42:50 -0700
changeset 398751 6a8652be7d95e8ea7c4d84a346e1d91cd9af3ea7
parent 397688 763fe887c37cee5fcfe0f00e94fdffc84a41ea1c
child 398752 40b121ee222da16181f0d521dd4705eeed3da86d
push id25616
push userbmo:ealvarez@mozilla.com
push dateTue, 09 Aug 2016 17:28:11 +0000
reviewersdholbert
bugs1000957
milestone51.0a1
Bug 1000957: Uncomment some flexbox warnings referencing fixed bugs. r?dholbert MozReview-Commit-ID: COy0I1nm3DU
layout/generic/nsFlexContainerFrame.cpp
--- a/layout/generic/nsFlexContainerFrame.cpp
+++ b/layout/generic/nsFlexContainerFrame.cpp
@@ -3479,23 +3479,19 @@ nsFlexContainerFrame::GenerateFlexLines(
 nscoord
 nsFlexContainerFrame::GetMainSizeFromReflowInput(
   const ReflowInput& aReflowInput,
   const FlexboxAxisTracker& aAxisTracker)
 {
   if (aAxisTracker.IsRowOriented()) {
     // Row-oriented --> our main axis is the inline axis, so our main size
     // is our inline size (which should already be resolved).
-    // XXXdholbert ISize may be (wrongly) unconstrained right now: bug 1163238
-    // Uncomment when that's fixed:
-    /*
     NS_WARN_IF_FALSE(aReflowInput.ComputedISize() != NS_UNCONSTRAINEDSIZE,
                      "Unconstrained inline size; this should only result from "
                      "huge sizes (not intrinsic sizing w/ orthogonal flows)");
-    */
     return aReflowInput.ComputedISize();
   }
 
   // Note: This may be unconstrained, if our block size is "auto":
   return GetEffectiveComputedBSize(aReflowInput);
 }
 
 // Returns the largest outer hypothetical main-size of any line in |aLines|.
@@ -3515,18 +3511,16 @@ GetLargestLineMainSize(const FlexLine* a
  * primarily based on:
  * - the "tentative" main size, taken from the reflow state ("tentative"
  *    because it may be unconstrained or may run off the page).
  * - the available BSize (needed if the main axis is the block axis).
  * - the sizes of our lines of flex items.
  *
  * Guaranteed to return a definite length, i.e. not NS_UNCONSTRAINEDSIZE,
  * aside from cases with huge lengths which happen to compute to that value.
- * XXXdholbert (this^ isn't quite true, if we're row-oriented and in an
- * orthogonal flow, per mentions of bug 1163238 in GetMainSizeFromReflowInput.)
  *
  * (Note: This function should be structurally similar to 'ComputeCrossSize()',
  * except that here, the caller has already grabbed the tentative size from the
  * reflow state.)
  */
 static nscoord
 ResolveFlexContainerMainSize(const ReflowInput& aReflowInput,
                              const FlexboxAxisTracker& aAxisTracker,
@@ -3588,23 +3582,19 @@ nsFlexContainerFrame::ComputeCrossSize(c
                                        bool* aIsDefinite,
                                        nsReflowStatus& aStatus)
 {
   MOZ_ASSERT(aIsDefinite, "outparam pointer must be non-null");
 
   if (aAxisTracker.IsColumnOriented()) {
     // Column-oriented --> our cross axis is the inline axis, so our cross size
     // is our inline size (which should already be resolved).
-    // XXXdholbert ISize may be (wrongly) unconstrained right now: bug 1163238.
-    // Uncomment when that's fixed:
-    /*
     NS_WARN_IF_FALSE(aReflowInput.ComputedISize() != NS_UNCONSTRAINEDSIZE,
                      "Unconstrained inline size; this should only result from "
                      "huge sizes (not intrinsic sizing w/ orthogonal flows)");
-    */
     *aIsDefinite = true;
     return aReflowInput.ComputedISize();
   }
 
   nscoord effectiveComputedBSize = GetEffectiveComputedBSize(aReflowInput);
   if (effectiveComputedBSize != NS_INTRINSICSIZE) {
     // Row-oriented case (cross axis is block-axis), with fixed BSize:
     *aIsDefinite = true;