Bug 1157323 - Part 6: Some comment improvements. draft
authorByron Campen [:bwc] <docfaraday@gmail.com>
Fri, 05 Aug 2016 13:46:07 -0500
changeset 417178 0a5970936c36c2209baa62d90af9b74cd88686ec
parent 417176 9c41628d5a0ec07e343b4e0edba361cefd70d1f1
child 532046 aa9a37f326ccc119112fa72dda4f6d77db56af64
push id30355
push userbcampen@mozilla.com
push dateFri, 23 Sep 2016 19:06:33 +0000
bugs1157323
milestone52.0a1
Bug 1157323 - Part 6: Some comment improvements. MozReview-Commit-ID: GDLuJS0Wlgh
xpcom/threads/nsTimerImpl.h
--- a/xpcom/threads/nsTimerImpl.h
+++ b/xpcom/threads/nsTimerImpl.h
@@ -140,26 +140,26 @@ public:
                                       uint32_t aDelay,
                                       uint32_t aType,
                                       Name aName);
 
   // This is set by Init. It records the name (if there is one) for the timer,
   // for use when logging timer firings.
   Name mName;
 
-  // These members are set by Init and never reset.
-  CallbackType          mCallbackType;
-
   // These members are set by the initiating thread, when the timer's type is
   // changed and during the period where it fires on that thread.
+  CallbackType          mCallbackType;
   uint8_t               mType;
 
   // The generation number of this timer, re-generated each time the timer is
   // initialized so one-shot timers can be canceled and re-initialized by the
   // arming thread without any bad race conditions.
+  // This is only modified on the target thread, and only after removing the
+  // timer from the TimerThread. Is set on the arming thread, initially.
   int32_t               mGeneration;
 
   uint32_t              mDelay;
   TimeStamp             mTimeout;
 
 #ifdef MOZ_TASK_TRACER
   mozilla::tasktracer::TracedTaskCommon mTracedTask;
 #endif