Bug 1255955 - Fix event.parseModifiers_ to not use module argument name; r?automatedtester draft
authorAndreas Tolfsen <ato@mozilla.com>
Fri, 05 Aug 2016 18:03:43 +0100
changeset 400454 7ff15853131bb796277e2843a4f56ad26973a615
parent 400453 31bec20e5a6cb0aaeb9f6f41d4e65673e05f49f1
child 400455 e8294130ca59acb8fd173b9b9313b823e81ba360
push id26147
push userbmo:ato@mozilla.com
push dateSat, 13 Aug 2016 19:00:38 +0000
reviewersautomatedtester
bugs1255955
milestone51.0a1
Bug 1255955 - Fix event.parseModifiers_ to not use module argument name; r?automatedtester MozReview-Commit-ID: v79foxRjUV
testing/marionette/event.js
--- a/testing/marionette/event.js
+++ b/testing/marionette/event.js
@@ -157,31 +157,31 @@ event.sendString = function(string, wind
  */
 event.sendKey = function(key, window = undefined) {
   let keyName = "VK_" + key.toUpperCase();
   event.synthesizeKey(keyName, {shiftKey: false}, window);
 };
 
 // TODO(ato): Unexpose this when action.Chain#emitMouseEvent
 // no longer emits its own events
-event.parseModifiers_ = function(event) {
+event.parseModifiers_ = function(modifiers) {
   let mval = 0;
-  if (event.shiftKey) {
+  if (modifiers.shiftKey) {
     mval |= Ci.nsIDOMNSEvent.SHIFT_MASK;
   }
-  if (event.ctrlKey) {
+  if (modifiers.ctrlKey) {
     mval |= Ci.nsIDOMNSEvent.CONTROL_MASK;
   }
-  if (event.altKey) {
+  if (modifiers.altKey) {
     mval |= Ci.nsIDOMNSEvent.ALT_MASK;
   }
-  if (event.metaKey) {
+  if (modifiers.metaKey) {
     mval |= Ci.nsIDOMNSEvent.META_MASK;
   }
-  if (event.accelKey) {
+  if (modifiers.accelKey) {
     if (navigator.platform.indexOf("Mac") >= 0) {
       mval |= Ci.nsIDOMNSEvent.META_MASK;
     } else {
       mval |= Ci.nsIDOMNSEvent.CONTROL_MASK;
     }
   }
   return mval;
 };