Bug 1255955 - Scroll element into view when not visible; r?automatedtester
The if-condition in the specification compatible interactability check
for interaction.clickElement is wrong. It should scroll an element into
view when it is _not_ visible. If it is visible it does not matter.
MozReview-Commit-ID: 2n34QddDkQv
--- a/testing/marionette/interaction.js
+++ b/testing/marionette/interaction.js
@@ -87,17 +87,17 @@ this.interaction = {};
* Use WebDriver specification compatible interactability definition.
*/
interaction.clickElement = function(el, strict = false, specCompat = false) {
let win = getWindow(el);
let visible = false;
if (specCompat) {
visible = element.isInteractable(el);
- if (visible) {
+ if (!visible) {
el.scrollIntoView(false);
}
} else {
visible = element.isVisible(el);
}
if (!visible) {
throw new ElementNotVisibleError("Element is not visible");