Bug 1292468 - Incorrect string comparison draft
authorSylvestre Ledru <sledru@mozilla.com>
Fri, 05 Aug 2016 10:45:10 +0200
changeset 397143 25768a2b31fa8b9d4a19ca3d8d81b3ffabeae739
parent 392430 2c232e55334900f0614c3fafa3cf59a85ce86db3
child 397149 a820922accad37166b32e4534755ebd170b5c005
push id25216
push usersledru@mozilla.com
push dateFri, 05 Aug 2016 08:46:37 +0000
bugs1292468
milestone50.0a1
Bug 1292468 - Incorrect string comparison MozReview-Commit-ID: G69dq8EFM5U
mobile/android/stumbler/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/DataStorageManager.java
--- a/mobile/android/stumbler/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/DataStorageManager.java
+++ b/mobile/android/stumbler/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/DataStorageManager.java
@@ -262,17 +262,17 @@ public class DataStorageManager {
     }
 
     public synchronized boolean isDirEmpty() {
         return (mFileList.mFiles == null || mFileList.mFiles.length < 1);
     }
 
     /* Pass filename returned from dataToSend() */
     public synchronized boolean delete(String filename) {
-        if (filename == MEMORY_BUFFER_NAME) {
+        if (filename.equals(MEMORY_BUFFER_NAME)) {
             mCurrentReportsSendBuffer = null;
             return true;
         }
 
         final File file = new File(mReportsDir, filename);
         final boolean ok = file.delete();
         mFileList.update(mReportsDir);
         return ok;