Bug 1274042 - Remove unnecessary edge case handling for E10S mode in prompt tests. r=Dolske draft
authorSaad Quadri <saad@saadquadri.com>
Fri, 12 Aug 2016 09:45:44 -0700
changeset 400039 72dd4d72458439e0f4f370f4494f2172a96bfac1
parent 400038 68f876db2221b7962efe3d3d719997aeed7fc650
child 528140 fa52fa9faea5a671f67d8a1c520ad0a255b1c46d
push id26076
push usersaad@saadquadri.com
push dateFri, 12 Aug 2016 16:46:31 +0000
reviewersDolske
bugs1274042
milestone51.0a1
Bug 1274042 - Remove unnecessary edge case handling for E10S mode in prompt tests. r=Dolske MozReview-Commit-ID: FKocwybNyib
toolkit/components/passwordmgr/test/prompt_common.js
toolkit/components/prompts/test/test_subresources_prompts.html
--- a/toolkit/components/passwordmgr/test/prompt_common.js
+++ b/toolkit/components/passwordmgr/test/prompt_common.js
@@ -1,8 +1,15 @@
+/**
+ * NOTE:
+ * This file is currently only being used for tests which haven't been
+ * fixed to work with e10s. Favor using the `prompt_common.js` file that
+ * is in `toolkit/components/prompts/test/` instead.
+ */
+
 var Ci = SpecialPowers.Ci;
 ok(Ci != null, "Access Ci");
 var Cc = SpecialPowers.Cc;
 ok(Cc != null, "Access Cc");
 
 var didDialog;
 
 var timer; // keep in outer scope so it's not GC'd before firing
--- a/toolkit/components/prompts/test/test_subresources_prompts.html
+++ b/toolkit/components/prompts/test/test_subresources_prompts.html
@@ -129,21 +129,16 @@ add_task(function* runTestAuth()
     passHidden  : false,
     checkHidden : true,
     checkMsg    : "",
     checked     : false,
     focused     : "textField",
     defButton   : "button0",
   };
 
-  if (isE10S) {
-    state.checkHidden = false;
-    state.checkMsg = "Use Password Manager to remember this password."
-  }
-
   action = {
     buttonClick : "ok",
     setCheckbox : false,
     textField   : "mochiuser1",
     passField   : "mochipass1",
   };
 
   promptDone = handlePrompt(state, action);
@@ -171,21 +166,16 @@ add_task(function* runTestAuth()
     passHidden  : false,
     checkHidden : true,
     checkMsg    : "",
     checked     : false,
     focused     : "textField",
     defButton   : "button0",
   };
 
-  if (isE10S) {
-    state.checkHidden = false;
-    state.checkMsg = "Use Password Manager to remember this password."
-  }
-
   action = {
     buttonClick : "ok",
     setCheckbox : false,
     textField   : "mochiuser2",
     passField   : "mochipass2",
   };
 
   promptDone = handlePrompt(state, action);