Bug 1289514 - Remove empty dataFailed method; r=catlee
The method was previously crippled. It was dispatching to its parent
class, making the method essentially worthless. The only value was
the commented code. And since that code dealt with recovering from
reset repos, which the previous commit and subsequent commits will
address, there is no value to the commented code so it can be
deleted.
MozReview-Commit-ID: 3QQMRR8A4oq
--- a/changes/hgpoller.py
+++ b/changes/hgpoller.py
@@ -267,29 +267,16 @@ class BaseHgPoller(BasePoller):
if '?' not in url:
url += '?'
else:
url += '&'
url += '&'.join(args)
return str(url)
- def dataFailed(self, res):
- # XXX: disabled for bug 774862
- # if hasattr(res.value, 'status') and res.value.status == '500' and \
- #'unknown revision' in res.value.response:
- ## Indicates that the revision can't be found. The repo has most
- ## likely been reset. Forget about our lastChangeset, and set
- ## emptyRepo to True so we can trigger builds for new changes there
- # if self.verbose:
- # log.msg("%s has been reset" % self.baseURL)
- # self.lastChangeset = None
- # self.emptyRepo = True
- return self.super_class.dataFailed(self, res)
-
def processData(self, query):
push_data = parse_pushlog_json(query)
# The payload tells us the most recent push ID. If it is the empty
# string, the pushlog is empty and there is no data to consume.
if not push_data['lastpushid']:
self.emptyRepo = True
self.lastPushID = None