--- a/browser/base/content/sanitize.js
+++ b/browser/base/content/sanitize.js
@@ -229,17 +229,16 @@ Sanitizer.prototype = {
})
},
cookies: {
clear: Task.async(function* (range) {
let seenException;
let yieldCounter = 0;
let refObj = {};
- TelemetryStopwatch.start("FX_SANITIZE_COOKIES", refObj);
// Clear cookies.
TelemetryStopwatch.start("FX_SANITIZE_COOKIES_2", refObj);
try {
let cookieMgr = Components.classes["@mozilla.org/cookiemanager;1"]
.getService(Ci.nsICookieManager);
if (range) {
// Iterate through the cookies and delete any created after our cutoff.
@@ -282,17 +281,16 @@ Sanitizer.prototype = {
// As evidenced in bug 1253204, clearing plugin data can sometimes be
// very, very long, for mysterious reasons. Unfortunately, this is not
// something actionable by Mozilla, so crashing here serves no purpose.
//
// For this reason, instead of waiting for sanitization to always
// complete, we introduce a soft timeout. Once this timeout has
// elapsed, we proceed with the shutdown of Firefox.
let promiseClearPluginCookies;
- TelemetryStopwatch.start("FX_SANITIZE_PLUGINS", refObj);
try {
// We don't want to wait for this operation to complete...
promiseClearPluginCookies = this.promiseClearPluginCookies(range);
//... at least, not for more than 10 seconds.
yield Promise.race([
promiseClearPluginCookies,
new Promise(resolve => setTimeout(resolve, 10000 /* 10 seconds */))
@@ -301,20 +299,16 @@ Sanitizer.prototype = {
seenException = ex;
}
// Detach waiting for plugin cookies to be cleared.
promiseClearPluginCookies.catch(() => {
// If this exception is raised before the soft timeout, it
// will appear in `seenException`. Otherwise, it's too late
// to do anything about it.
- }).then(() => {
- // Finally, update statistics.
- TelemetryStopwatch.finish("FX_SANITIZE_PLUGINS", refObj);
- TelemetryStopwatch.finish("FX_SANITIZE_COOKIES", refObj);
});
if (seenException) {
throw seenException;
}
}),
promiseClearPluginCookies: Task.async(function* (range) {
@@ -356,25 +350,19 @@ Sanitizer.prototype = {
}
}
}
})
},
offlineApps: {
clear: Task.async(function* (range) {
- let refObj = {};
- TelemetryStopwatch.start("FX_SANITIZE_OFFLINEAPPS", refObj);
- try {
- Components.utils.import("resource:///modules/offlineAppCache.jsm");
- // This doesn't wait for the cleanup to be complete.
- OfflineAppCacheHelper.clear();
- } finally {
- TelemetryStopwatch.finish("FX_SANITIZE_OFFLINEAPPS", refObj);
- }
+ Components.utils.import("resource:///modules/offlineAppCache.jsm");
+ // This doesn't wait for the cleanup to be complete.
+ OfflineAppCacheHelper.clear();
})
},
history: {
clear: Task.async(function* (range) {
let seenException;
let refObj = {};
TelemetryStopwatch.start("FX_SANITIZE_HISTORY", refObj);
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -3399,17 +3399,17 @@
"kind": "exponential",
"low": 1000,
"high": 150000,
"n_buckets": 20,
"releaseChannelCollection": "opt-out",
"description": "PLACES: Number of unique pages"
},
"PLACES_MOST_RECENT_EXPIRED_VISIT_DAYS": {
- "alert_emails": ["mbonardo@mozilla.com"],
+ "alert_emails": ["firefox-dev@mozilla.org"],
"expires_in_version": "never",
"kind": "linear",
"low": 30,
"high": 730,
"n_buckets": 12,
"description": "PLACES: the most recent expired visit in days"
},
"PLACES_BOOKMARKS_COUNT": {
@@ -4536,25 +4536,25 @@
"description": "Number of toplevel location changes in tablet and desktop mode (only used on win10 where tablet mode is available)"
},
"FX_TOUCH_USED": {
"expires_in_version": "46",
"kind": "count",
"description": "Windows only. Counts occurrences of touch events"
},
"FX_URLBAR_SELECTED_RESULT_INDEX": {
- "alert_emails": ["mbonardo@mozilla.com"],
- "expires_in_version": "50",
+ "alert_emails": ["firefox-dev@mozilla.org"],
+ "expires_in_version": "55",
"kind": "enumerated",
"n_values": 17,
"bug_numbers": [775825],
"description": "Firefox: The index of the selected result in the URL bar popup"
},
"FX_URLBAR_SELECTED_RESULT_TYPE": {
- "alert_emails": ["mbonardo@mozilla.com"],
+ "alert_emails": ["firefox-dev@mozilla.org"],
"expires_in_version": "never",
"kind": "enumerated",
"n_values": 14,
"bug_numbers": [775825],
"description": "Firefox: The type of the selected result in the URL bar popup. See nsBrowserGlue.js::_handleURLBarTelemetry for the result types."
},
"INNERWINDOWS_WITH_MUTATION_LISTENERS": {
"expires_in_version": "never",
@@ -8333,115 +8333,91 @@
"expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Total time it takes to sanitize (ms)"
},
"FX_SANITIZE_CACHE": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize the cache (ms)"
},
- "FX_SANITIZE_COOKIES": {
- "alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
- "kind": "exponential",
- "high": 30000,
- "n_buckets": 20,
- "description": "Sanitize: Time it takes to sanitize cookies (ms)"
- },
"FX_SANITIZE_COOKIES_2": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize firefox cookies (ms). A subset of FX_SANITIZE_COOKIES."
},
- "FX_SANITIZE_PLUGINS": {
- "alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
- "kind": "exponential",
- "high": 30000,
- "n_buckets": 20,
- "description": "Sanitize: Time it takes to sanitize plugin cookies (ms). A subset of FX_SANITIZE_COOKIES."
- },
"FX_SANITIZE_LOADED_FLASH": {
"alert_emails": ["firefox-dev@mozilla.org"],
"bug_numbers": [1251469],
- "expires_in_version": "50",
+ "expires_in_version": "55",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize Flash when it's already loaded (ms). A subset of FX_SANITIZE_PLUGINS."
},
"FX_SANITIZE_UNLOADED_FLASH": {
"alert_emails": ["firefox-dev@mozilla.org"],
"bug_numbers": [1251469],
- "expires_in_version": "50",
+ "expires_in_version": "55",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize Flash when it's not yet loaded (ms). A subset of FX_SANITIZE_PLUGINS."
},
- "FX_SANITIZE_OFFLINEAPPS": {
- "alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
- "kind": "exponential",
- "high": 30000,
- "n_buckets": 20,
- "description": "Sanitize: Time it takes to sanitize stored offline app data (ms)"
- },
"FX_SANITIZE_HISTORY": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize history (ms)"
},
"FX_SANITIZE_FORMDATA": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize stored form data (ms)"
},
"FX_SANITIZE_DOWNLOADS": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize recent downloads (ms)"
},
"FX_SANITIZE_SESSIONS": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize saved sessions (ms)"
},
"FX_SANITIZE_SITESETTINGS": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize site-specific settings (ms)"
},
"FX_SANITIZE_OPENWINDOWS": {
"alert_emails": ["firefox-dev@mozilla.org"],
- "expires_in_version": "50",
+ "expires_in_version": "never",
"kind": "exponential",
"high": 30000,
"n_buckets": 20,
"description": "Sanitize: Time it takes to sanitize the open windows list (ms)"
},
"PWMGR_BLOCKLIST_NUM_SITES": {
"expires_in_version": "never",
"kind": "exponential",