Bug 1289366 - added return statement for CharToByte when assertion fails. r?keeler draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 26 Jul 2016 12:48:49 +0300
changeset 392755 cd5803213ecd91f5c97e02df746b2cb17f0e83d4
parent 392445 251fccc1f62bf0eac569ef4f6717fea61ebadb27
child 526412 70afceefeb2fbce08bb87f8106d3076bbc0c2c85
push id24124
push userbmo:bpostelnicu@mozilla.com
push dateTue, 26 Jul 2016 09:49:19 +0000
reviewerskeeler
bugs1289366
milestone50.0a1
Bug 1289366 - added return statement for CharToByte when assertion fails. r?keeler MozReview-Commit-ID: LDAamOxHdli
security/certverifier/tests/gtest/CTTestUtils.cpp
--- a/security/certverifier/tests/gtest/CTTestUtils.cpp
+++ b/security/certverifier/tests/gtest/CTTestUtils.cpp
@@ -120,16 +120,17 @@ CharToByte(char c)
   if (c >= '0' && c <= '9') {
     return c - '0';
   } else if (c >= 'a' && c <= 'f') {
     return c - 'a' + 10;
   } else if (c >= 'A' && c <= 'F') {
     return c - 'A' + 10;
   }
   MOZ_RELEASE_ASSERT(false);
+  return 0;
 }
 
 static Buffer
 HexToBytes(const char* hexData)
 {
   size_t hexLen = strlen(hexData);
   MOZ_RELEASE_ASSERT(hexLen > 0 && (hexLen % 2 == 0));
   size_t resultLen = hexLen / 2;